Skip to content

Fix notes count on MR to not increment when notes are loading

Patrick Bajao requested to merge 368216-fix-incrementing-mr-comments-count into master

What does this MR do and why?

Before this fix, when there are multiple pages of discussions, it's noticeable that the notes count on the MR page will increment while discussions are getting loaded.

In this fix, we only update the count when all the pages of discussions are done loading.

This is behind paginated_mr_discussions feature flag.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #368216 (closed)

Edited by Patrick Bajao

Merge request reports