Skip to content

Fix missing relative_url_root settings update

Miguel Rincon requested to merge 367217-the-switch-for-shared-runners-at-group-level-does-not-use-the-correct-url-uri-in-the-rest into master

What does this MR do and why?

Fixes #367217 (closed)

This change adds the relative_url_root to the settings update call for runner settings. It fixes issues when GitLab instances use e.g. https://apps.example.com/gitlab instead of https://gitlab.example.com.

Screenshots or screen recordings

related view

How to set up and validate locally

  1. In GDK, use a non-empty relative URL root:
# gdk.yml
# ...
relative_url_root: '/gitlab'
  1. gdk reconfigure
  2. gdk restart
  3. As a owner of a group visit the Group -> Settings -> CI/CD e.g. http://gdk.test:3000/groups/h5bp/-/settings/ci_cd
  4. Click Enable shared runners for this group and Allow projects and subgroups to override the group setting

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #367217 (closed)

Edited by Miguel Rincon

Merge request reports