Skip to content

Resolve "Move Group Push Rules to Settings > Repository"

Thomas Hutterer requested to merge 220365-move-group-push-rules-to-settings-repository into master

What does this MR do and why?

Resolves #220365 (closed), so this removes the Push Rules item from the group sidebar and makes it a section in the Settings/Repository page instead.

The technical challenge here was that push rules can also be edited by group maintainers, while the Settings menu was only visible and accessible by group owners.

So the second commit in this MR takes care of that and shows a Settings menu that only holds a single Repository item for group maintainers. The settings view itself takes care of the rest, hiding all sections except the one for the push rules.

Screenshots or screen recordings

As group owner

Screencast_from_21.07.2022_15_01_15

As group maintainer

Screencast_from_01.08.2022_14_01_36

How to set up and validate locally

  • This is a Premium feature.
  • Go to any group where you rights to change push rules.
  • Verify the Push Rules item in the left sidebar is no more.
  • Go to the group's Settings > Repository.
  • See a new expandable section here. Edit the group's push rules, save.
  • Verify it got saved and that the Push Rules section is expanded on page load.

Now impersonate another user who is maintainer in the same group.

  • You should see a Settings menu in the sidebar now.
  • There should only be a single Repository item.
  • Click it and make sure all you see is the Push Rules section, no other settings.
  • Expand, make a change, save.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Thomas Hutterer

Merge request reports