Skip to content

Adjust Error Message for MR Merge When Over Namespace Storage Limits

Jason Goodman requested to merge change-namespace-merge-error-text into master

What does this MR do and why?

Adjust the error message seen when a user attempts to merge an MR when the merge request is over the namespace storage limit.

This is a follow up from here: !92567 (comment 1032629282)

Since this error is stored in the database, it could potentially become incorrect when storage is purchased or limits change.

We also display a bigger banner on the page with correct values. Should we leave out the value from the message that's stored and just display the reason and a potential fix?

This will also close https://gitlab.com/gitlab-org/gitlab/-/issues/368422.

Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/362945

Screenshots or screen recordings

Before

Screen_Shot_2022-07-20_at_1.07.01_PM

After

MRMergeError-small

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jason Goodman

Merge request reports