Skip to content

Remove complex docker logic and replace it with a simple clean gitlab ci job.

Marcel requested to merge pleaseadvise/gitlab:fix-code-quality into master

What does this MR do and why?

  • Replace complex docker logic with clean code for better maintainability
  • The previous logic to start docker is very slow and leads to long execution times
  • Code is aligned with the other Job Templates provided by gitlab
  • The current Code-Quality job is broken, because the intent of "artifacts" section is wrong.

How to set up and validate locally

Setup a project with a language that is supported by code climate. Add something to the project where code climate should give a warning.

Include the Job template to ensure that it is executed:

include:
  - project: '$CI_PROJECT_PATH'
    file: '$CI_CONFIG_PATH'
    ref: '$CI_COMMIT_REF_NAME'
  - remote: 'https://gitlab.com/pleaseadvise/gitlab/-/raw/fix-code-quality/lib/gitlab/ci/templates/Jobs/Code-Quality.gitlab-ci.yml?inline=false'

Numbered steps to set up and validate the change are strongly suggested.

  1. Setup a project with code that is supported by code climate
  2. Include the job template (see above)
  3. Run the pipeline and verify the artifact created

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports