Skip to content

Fix: notify locale on merge request unmergeable

Wu Jeremy requested to merge gitlab-jh/jh-team/gitlab:fix/notify-locale-on-merge-request-unmergeable into master

What does this MR do and why?

Reason

Right now the email template for merge request unmergeable notification can only be sent in English

Result

  • in this MR I updated the template with i18n enabled strings instead of hardcoded strings. After this MR it will be able to send languages the user prefers.
  • I also updated the variable referencing to use the same parameter that passed to the method instead of instance member.

/cc @prajnamas @orozot @qk44077907 @mtan-gitlab @zhzhang93

Screenshots or screen recordings

image

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

  1. Start your GDK instance locally or via gitpod or other ways
  2. Open the browser with your instance with path gdk/rails/mailers/notify/merge_request_unmergeable_email
  3. Observe.

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Wu Jeremy

Merge request reports