Skip to content

Improve error message when providing an invalid deploy key

David Barr requested to merge davebarr/gitlab:23277-deploy-key-improve-verbose-error-output into master

What does this MR do and why?

This MR improves the error message when providing an invalid deploy key by using a single succinct error message when a deploy key is invalid, instead of returning all validation errors.

Screenshots or screen recordings

Before After
Screen_Shot_2022-07-19_at_23.03.16 2022-10-04_15-01

How to set up and validate locally

  1. Visit http://localhost:3000/flightjs/Flight/-/settings/repository
  2. Under "Deploy keys", add a title and put any bogus text for the key
  3. Click "Add Key"
  4. View the new flash popup message
  5. Confirm the help link opens a new window to the SSH key page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #23277 (closed)

Edited by Shinya Maeda

Merge request reports