Skip to content

Fix WorkItems::CreateService transaction_create

Mario Celi requested to merge 362208-fix-transaction-result-create-work-item into master

What does this MR do and why?

A bug was found in https://gitlab.slack.com/archives/CETG54GQ0/p1658177447311299 (internal only).

WorkItems::CreateService executes widgets inside a transaction. transaction_create method needs to return false in order to rollback the transaction and signal a failed work item creation. The implementation was returning the value from the inherited class even if the parent class returns false when calling super.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #362208 (closed)

Merge request reports