Extract a `ProtectedBranchAccessEe` module
Summary
- gitlab-org/gitlab-ee#1137 is a
technical debt
issue to clean up the EE protected branch access levels (for users and groups) implementation. - Some of this cleanup bleeds over to code shared by CE and EE. This portion is covered in this CE merge request: gitlab-org/gitlab-ce!7821
References
- Closes #1137 (closed)
Tasks
-
#1137 (closed) Follow-up from restricting pushes / merges by group -
Implementation -
Prefer validates
with:uniqueness
option! -
Could this be moved into ProtectedBranchAccess
? -
Please name controller action specs after the method and action: describe "GET project_groups"
-
I think we need more extensive integration specs here -
Does this need to be a proc?
-
-
Tests -
Added -
Passing
-
-
Meta -
CHANGELOG entry created -
Documentation created/updated -
API support added -
Branch has no merge conflicts with master
-
Squashed related commits together -
Check for clean merge with EE -
Added screenshots
-
-
Review -
Endboss -
Miniboss
-
-
Wait for merge
-