Skip to content

Add success messages to streaming audit events

Robert Hunt requested to merge add-success-messages-to-custom-headers into master

What does this MR do and why?

This MR adds success messages to the streaming audit events UI. Previously, the UI just refreshed the page and didn't give any indication that the change was successful other than it appearing on the page and no error messages.

This change updates the logic to make sure we show success messages and clears them in the event of a new mutation or error.

Screenshots or screen recordings

Screen_Recording_2022-07-22_at_15.22.18

How to set up and validate locally

  1. Enable the feature flag :custom_headers_streaming_audit_events_ui: echo "Feature.enable(:custom_headers_streaming_audit_events_ui)" | rails c.
  2. Visit a group's audit events page e.g. http://gdk.test:3000/groups/gitlab-org/-/audit_events and look at the Streams tab.
  3. Select the add button and add a new destination item.
  4. Confirm the successfully added message is shown.
  5. Select the edit button on a destination item.
  6. Change the values of the headers in the destination item.
  7. Select the save button and confirm the successfully saved message is shown.
  8. Select the delete button on a destination item.
  9. Confirm the successfully deleted message is shown.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Robert Hunt

Merge request reports