Skip to content

Feat: add translation support for omniauth_error page

ARCHIVED - Martin Tan requested to merge gitlab-jh/jh-team/gitlab:add-translation-support-for-omniauth-error into master

related to MR on JiHu

What does this MR do and why?

We've find that the omniauth_error page is with hardcoded texts in its haml template during the process of doing i18n chores from JiHu side.

We're going to rewrite the texts with methods from gettext Gem to let this page have the ability of changing text translations based on user preferred language.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Register a new user on GitLab
  2. Register a new user on GitHub with the same email from previous step
  3. Goto sign up page on GitLab
  4. Click on GitHub button
  5. You should see the omniauth_error page as the same as before

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

/cc @prajnamas

Edited by ARCHIVED - Martin Tan

Merge request reports