Skip to content
Snippets Groups Projects

Fetch child epics with colours when FF is enabled

What does this MR do and why?

When fetching Child Epics on the roadmap page, with the epic_color_highlight feature flag enabled, we need to fetch all of the child epics and also request the color and textColor attributes as part of the GraphQL query.

The top level epics make use of the groupEpics query, but child epics use a different query called epicChildEpics. In the previous MR (Use Epic colours for display on the roadmap (!89709 - merged)), this second query was missed and thus didn't get updated.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

  1. Enable epic_color_highlight feature flag (Feature.enable(:epic_color_highlight, Group.find_by_full_path('flightjs')))
  2. Update an epic in the flightjs group so that is has a parent epic and a colour other than Blue
  3. Visit the roadmap page (http://gdk.test:3000/groups/flightjs/-/roadmap)
  4. Expand the parent epic and notice that the colour of the child epic is always Blue
  5. Apply this MR and reload the page
  6. Expanding the child epic will now fetch the correct epic colour

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #7641 (closed)

Edited by Andrew Smith

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks so much for working on this @espadav8! I've left a comment for you which you might have been anticipating :wink:

    Back to you! :soccer:

  • Paul Slaughter removed review request for @pslaughter

    removed review request for @pslaughter

  • Paul Slaughter mentioned in merge request !90975 (merged)

    mentioned in merge request !90975 (merged)

  • requested review from @brytannia

  • Tetiana Chupryna changed milestone to %15.3

    changed milestone to %15.3

  • Tetiana Chupryna removed review request for @brytannia

    removed review request for @brytannia

  • Andrew Smith added 1 commit

    added 1 commit

    • 94955195 - Remove duplicated query file

    Compare with previous version

  • requested review from @pslaughter

  • @pslaughter, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
    • Add the workflowin dev label if the merge request needs action from the author.

    This message was generated automatically. You're welcome to improve it.

  • Nick Leonard requested review from @nickleonard

    requested review from @nickleonard

  • Nick Leonard removed review request for @nickleonard

    removed review request for @nickleonard

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading