Fetch child epics with colours when FF is enabled
What does this MR do and why?
When fetching Child Epics on the roadmap page, with the epic_color_highlight
feature flag enabled, we need to fetch all of the child epics and also request the color
and textColor
attributes as part of the GraphQL query.
The top level epics make use of the groupEpics
query, but child epics use a different query called epicChildEpics
. In the previous MR (Use Epic colours for display on the roadmap (!89709 - merged)), this second query was missed and thus didn't get updated.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
- Enable
epic_color_highlight
feature flag (Feature.enable(:epic_color_highlight, Group.find_by_full_path('flightjs'))
) - Update an epic in the
flightjs
group so that is has a parent epic and a colour other thanBlue
- Visit the roadmap page (
http://gdk.test:3000/groups/flightjs/-/roadmap
) - Expand the parent epic and notice that the colour of the child epic is always
Blue
- Apply this MR and reload the page
- Expanding the child epic will now fetch the correct epic colour
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #7641 (closed)
Merge request reports
Activity
added typefeature label
Hey @espadav8!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help moving the MR forward, feel free to post
@gitlab-bot help
. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @espadav8
2 Warnings b93822ec: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Sheldon Led ( @sheldonled
) (UTC+1)Natalia Tepluhina ( @ntepluhina
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Andrew Smithadded 62 commits
-
8967e8e7...75547cd8 - 61 commits from branch
gitlab-org:master
- 278f32d3 - Fetch child epics with colour when FF is enabled
-
8967e8e7...75547cd8 - 61 commits from branch
- Resolved by Andrew Smith
Hello again @anna_vovchenko
It's been a long time :) Hope you are doing well.
I'm stilling working on the colours for epics
Would you mind doing a frontend review for this please? There as a query update that was missed in a previous MR when showing the epics on the roadmap page.
The duplication of the query is, unfortunately, needed until at least %15.3 due to the way the feature flag works on the backend. I have another issue/MR open to remove the duplicated query files once that has been released.
If you have any issues with this, just let me know. Thanks
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@gitlab-bot ready @anna_vovchenko
added workflowready for review label and removed workflowin dev label
requested review from @anna_vovchenko
@anna_vovchenko, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
mentioned in issue gitlab-org/quality/triage-reports#8319 (closed)
mentioned in issue gitlab-org/quality/triage-reports#8334 (closed)
changed milestone to %15.2
removed review request for @anna_vovchenko
- Resolved by Paul Slaughter
@anna_vovchenko
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @ntepluhina
,@filipa
,@jivanvl
,@kushalpandya
,@engwan
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added frontend label
2 Warnings f3bbe940: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Himanshu Kapoor ( @himkp
) (UTC+2)Zack Cuddy ( @zcuddy
) (UTC-5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 6f02c1d7 and 764739dd
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.6 MB 3.5 MB -98.11 KB -2.7 % mainChunk 1.98 MB 1.9 MB -82.81 KB -4.1 % Significant Reduction: 49Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.profiles.keys 673.78 KB 345.65 KB -328.13 KB -48.7 % pages.projects.merge_requests.show 5.69 MB 5.53 MB -167.63 KB -2.9 % pages.projects.settings.ci_cd.show 2.77 MB 2.67 MB -104.43 KB -3.7 % pages.projects.issues.designs 4.67 MB 4.56 MB -103.89 KB -2.2 % pages.projects.issues.show 4.67 MB 4.56 MB -103.89 KB -2.2 % pages.projects.incidents.show 4.62 MB 4.52 MB -101.72 KB -2.1 % pages.projects.issues.edit 4.55 MB 4.46 MB -96.45 KB -2.1 % pages.projects.issues.new 4.55 MB 4.46 MB -96.45 KB -2.1 % pages.projects.issues.service_desk 4.51 MB 4.42 MB -94.27 KB -2.0 % pages.projects.security.vulnerabilities.show 3.03 MB 2.96 MB -70.63 KB -2.3 % The table above is limited to 10 entries. Please look at the full report for more details
Note: We do not have exact data for 6f02c1d7. So we have used data from: b82e80a1.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 278f32d3expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Manage | 37 | 0 | 2 | 39 | 39 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 123 | 0 | 9 | 125 | 132 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
changed milestone to %Backlog
changed milestone to %15.2
removed [deprecated] Accepting merge requests label
- Resolved by Paul Slaughter
@dgruzd, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
requested review from @dgruzd
requested review from @pslaughter and removed review request for @dgruzd
added 1 commit
- 40eb9dbb - Fetch child epics with colour when FF is enabled
- Resolved by Paul Slaughter
Thanks so much for working on this @espadav8! I've left a comment for you which you might have been anticipating
Back to you!
removed review request for @pslaughter
mentioned in merge request !90975 (merged)
- Resolved by Paul Slaughter
@brytannia, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
requested review from @brytannia
changed milestone to %15.3
removed review request for @brytannia
added workflowin dev label and removed workflowready for review label
added workflowready for review label and removed workflowin dev label
requested review from @pslaughter
@pslaughter, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
- Resolved by Paul Slaughter
Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.
This message was generated automatically. You're welcome to improve it.
mentioned in issue gitlab-com/www-gitlab-com#13718 (closed)
requested review from @nickleonard
removed review request for @nickleonard