Fixes all visible mentions of work items in UI
What does this MR do and why?
When we scoped back from "work items" to "tasks", a few instances of UI text still stayed in the product. This MR fixes these.
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
Enable the work_items feature flag
Feature.enable(:work_items)
- Visit any group or project issue page, add a checklist to issue description
- Hover a checklist item, click "Convert to task"
- Task is created, Modal opens in edit view
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.2
assigned to @mvanremmerden
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @psimyn
,@dbalexandre
,@mayra-cabrera
,@marin
,@dzaporozhets
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/tasks.md
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Jeremy Jackson ( @jejacks0n
) (UTC-6)Natalia Tepluhina ( @ntepluhina
) (UTC+2)UX Jeremy Elder ( @jeldergl
) (UTC-5)Jeremy Elder ( @jeldergl
) (UTC-5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Marcel van Remmerden
@psimyn This is a follow-up to !90466 (merged), I caught some additional pieces of outdated UI text. Feel free to change the approach if you want to make it more flexible how the UI text is built, I tried to make it the smallest change possible, but I don't know if you all already had thought about how to deal with work item types as UI text and translations, etc...
@nickleonard Would you also mind having another look to see if I have missed some other elements? I will afterwards also assign the roulette chosen designer as final reviewer, but wanted to make sure you are aware
requested review from @psimyn and @nickleonard
added UX label
removed workflowpost-deploy-db-production label
added UI polish priority4 severity4 typebug + 1 deleted label and removed typefeature label
removed featureenhancement label
mentioned in issue #366210 (closed)
- Resolved by Marcel van Remmerden
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 85bef9fc and 45a95f67
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent mainChunk 1.88 MB 1.88 MB - 0.0 % average 3.45 MB 3.45 MB - 0.0 %
Note: We do not have exact data for 85bef9fc. So we have used data from: 13c20643.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 45a95f67expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Manage | 38 | 0 | 2 | 40 | 40 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 133 | 0 | 9 | 135 | 142 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
- A deleted user
added documentation label
requested review from @dmoraBerlin