Add display name description when Service Desk is not enabled
What does this MR do and why?
Currently, when Incoming Email (incoming_email
) has been enabled, but not Service Desk (service_desk_email
), some settings are displayed under a Project in Settings > General > Service Desk.
One option, "Email display name" shows only the label, with the text form and description text not shown if Service Desk has not been enabled in GitLab configuration. In its current state, this can cause confusion for some customers, as they want to use the feature but don't know that Service Desk must be enabled as well.
This MR replicates the same wording as the "Email address suffix" section on the same settings page, directing a user to set up Service Desk if they want to utilise this feature.
Screenshots or screen recordings
Both Before and After are shown with incoming_email
setting enabled
set to true
, but service_desk_email
enabled
set to false
.
Before MR | After MR |
---|---|
When Service Desk has been enabled, (service_desk_email
set to true
) the view is updated to:
How to set up and validate locally
- Deploy a Development instance of GitLab on the associated branch (
benjaminking-servicedesk-settings
) - Navigate and open
config/gitlab.yml
. Underincoming_email
setenabled:
totrue
. - Restart the development instance services.
- Navigate to any open project, then select Settings > General.
- Scroll-down to Service Desk. Because
incoming_email
is enabled, but notservice_desk
, the helpful description will be displayed.
Similarly, to test the behaviour with Service Desk enabled:
-
- Navigate and open
config/gitlab.yml
again. Underservice_desk_email
setenabled:
totrue
.
- Navigate and open
- Restart the development instance services.
- If on the same settings page, perform a reload of the page, or otherwise navigate back to the same same Settings location.
- Notice with Service Desk enabled, the value is definable as intended.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.