Update grafana_link_enabled metric definition
What does this MR do and why?
Describe in detail what your merge request does and why.
Update grafana_link_enabled definition.
Guided by docs here https://docs.gitlab.com/ee/administration/monitoring/performance/grafana_configuration.html
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.2
assigned to @alinamihaila
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @mikolaj_wawrzyniak
,@agarciatesares
,@alinamihaila
,@rkadam3
,@lmejia2
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added product intelligence product intelligencereview pending labels
1 Warning For the following files, a review from the Data team and Product Intelligence team is recommended
Please check the product intelligence Service Ping guide or the Snowplow guide.For MR review guidelines, see the Service Ping review guidelines or the Snowplow review guidelines.
config/metrics/settings/20210204124922_grafana_link_enabled.yml
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer product intelligence Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, 2.5 hours ahead of@alinamihaila
)Maintainer review is optional for product intelligence To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Albert
Hello @kbychu!
Could you please review this update for the grafana_link_enabled Service Ping metric when you have the chance? Thank you!
I think should belong to grouprespond
Edited by Alina Mihaila
requested review from @kbychu
added sectionanalytics label
@kbychu
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @alberts-gitlab
enabled an automatic merge when the pipeline for 413896e1 succeeds
LGTM @alinamihaila
mentioned in commit 24fc0fd4
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label