Work Items - Tasks First Time Experience
What does this MR do and why?
Any time a user visits a work item, he should see an alert/info having links to the doc page of gitlab for a detailed explanation. This information will be seen either when a work item(right now task) is viewed in modal/full page view
Screenshots or screen recordings
How to set up and validate locally
Make sure :work_items
feature flag is enabled if the changes are not visible in the local environment
Feature.enable(:work_items)
Example below:
- To create a work item/task , open any issue and create checkboxes/tasks list in the description.
- When you view the issue after saving and hover over any list item , you will see a small icon at the end of the item , click on that.
- A modal will be opened , and here is your first work item created when you close it. Now that will be converted to a link.
- Visit any work item in full page view/modal such as
http://127.0.0.1:3000/gitlab-instance-3485f007/Monitoring/-/work_items/505
- You should see the alert only the first time you visit a task, since you will be testing in your machine the first time , you will see the first time by default but not after that
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #366687 (closed)
Merge request reports
Activity
changed milestone to %15.2
assigned to @deepika.guliani
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @mayra-cabrera
,@dbalexandre
,@marin
,@dzaporozhets
,@tkuah
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- A deleted user
added frontend label
1 Warning 6ac0c3b9: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Mireya Andres ( @mgandres
) (UTC+8)Robert Hunt ( @rob.hunt
) (UTC+1)UX Nadia Sotnikova ( @nadia_sotnikova
) (UTC+3)Amelia Bauerly ( @ameliabauerly
) (UTC-7)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 192209cc and 6ac0c3b9
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.45 MB 3.45 MB - 0.0 % mainChunk 1.88 MB 1.88 MB - 0.0 %
Note: We do not have exact data for 192209cc. So we have used data from: fac0000f.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 6ac0c3b9expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Manage | 38 | 0 | 2 | 40 | 40 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 133 | 0 | 9 | 135 | 142 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
added 87 commits
-
f71ef5a5...2112516a - 86 commits from branch
master
- e7687fd2 - Work Items - Tasks First Time Experience
-
f71ef5a5...2112516a - 86 commits from branch
added workflowin dev label and removed workflowready for development label
added 143 commits
-
e7687fd2...e38baeb8 - 141 commits from branch
master
- e19a54ba - Work Items - Tasks First Time Experience
- 47532d83 - Basic local storage logic
-
e7687fd2...e38baeb8 - 141 commits from branch
added 203 commits
-
d6613f6c...6e682720 - 199 commits from branch
master
- 05ec445b - Work Items - Tasks First Time Experience
- 22352240 - Basic local storage logic
- 1a734a85 - Full view length modal same view
- 93d4a329 - Revert changes for modal view and link in sprintf text
Toggle commit list-
d6613f6c...6e682720 - 199 commits from branch
requested review from @nickleonard
- Resolved by Natalia Tepluhina
Hi @nickleonard ! Can you please do a UX review for this while I am working on the specs , just to be sure if the behavior is expected. The first time you access any task ( which is a work item ) you should see the information/alert.
Thank you !
- Resolved by Natalia Tepluhina
added 216 commits
-
93d20f6a...af532434 - 214 commits from branch
master
- adc84627 - Work Items - Tasks First Time Experience
- 9b7aeaf8 - Variant changed to tip from alert
-
93d20f6a...af532434 - 214 commits from branch
added 9 commits
-
9b7aeaf8...c26682b7 - 6 commits from branch
master
- d305e40a - Work Items - Tasks First Time Experience
- 84feaa6d - Variant changed to tip from alert
- 38996524 - Eslint changes and specs basic changes
Toggle commit list-
9b7aeaf8...c26682b7 - 6 commits from branch
added UX label
mentioned in issue #367558 (closed)
added 171 commits
-
c5f2343c...0f07e810 - 169 commits from branch
master
- a9159d2c - Work Items - Tasks First Time Experience
- 77912dd9 - Specs updated
-
c5f2343c...0f07e810 - 169 commits from branch
requested review from @mgandres
- Resolved by Natalia Tepluhina
Hi @mgandres ! Can you please go through the MR for a review ?
Edited by Deepika Guliani
added workflowin review label and removed workflowin dev label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Mireya Andres
- Resolved by Mireya Andres
- Resolved by Mireya Andres
- Resolved by Mireya Andres
- Resolved by Mireya Andres
Hi @mgandres ! I have done the changes , can you please have a look again ?
Also , I have a question - I usedhelpPagePath('ee/user/tasks.html')
to get the help page link which points tohttps://docs.gitlab.com/ee/user/tasks.html
, but in local it points tohttp://127.0.0.0:3000/ee/user/tasks.html
, how do we make sure that it points to the correct url in staging/prod ? `Edited by Deepika Guliani
requested review from @nadia_sotnikova
- Resolved by Natalia Tepluhina
Hi @nadia_sotnikova ! Can you please have a look this for UX review ?
Thank you !
added 11 commits
-
159f93aa...030a99b7 - 10 commits from branch
master
- bbb550f4 - Work Items - Tasks First Time Experience
-
159f93aa...030a99b7 - 10 commits from branch
@nickleonard After the latest pull from master with new task actions merged as well - here are the screeshots
See the 2 dismiss icons in the modal
Edited by Deepika Guliani- Resolved by Mireya Andres