Refactor Members ActivateService

marked this merge request as draft

changed title from WIP to Draft: Refactor Members ActivateService

Suggested Reviewers (beta)

The individuals below may be good candidates to participate in the review based on various factors.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Suggested Reviewers
`@mayra-cabrera`, `@dbalexandre`, `@dzaporozhets`, `@marin`, `@tkuah`

If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

	1 Warning
	This merge request is quite big (773 lines changed), please consider splitting it into multiple merge requests.

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Harsimar Sandhu (`@harsimarsandhu`) (UTC+5.5, 3.5 hours ahead of `@nicolasdular`)	Sean Arnold (`@seanarnold`) (UTC+12, 10 hours ahead of `@nicolasdular`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

@nicolasdular - please add typebug typefeature, typemaintenance or a subtype label to this merge request.

typebug: Defects in shipped code and fixes for those defects. This includes all the bug types (availability, performance, security vulnerability, mobile, etc.)
typefeature: Effort to deliver new features, feature changes & improvements. This includes all changes as part of new product requirements like application limits.
typemaintenance: Up-keeping efforts & catch-up corrective improvements that are not Features nor Bugs. This includes restructuring for long-term maintainability, stability, reducing technical debt, improving the contributor experience, or upgrading dependencies.

See the handbook for more guidance on classifying.

This message was created with automation and Engineering Productivity is looking for feedback in this issue: https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues/43

Allure report

allure-report-publisher generated test report!

review-qa-blocking: test report for 99dfc94c

expand test summary

+---------------------------------------------------------------------------+
|                              suites summary                               |
+----------------------+--------+--------+---------+-------+-------+--------+
|                      | passed | failed | skipped | flaky | total | result |
+----------------------+--------+--------+---------+-------+-------+--------+
| Plan                 | 47     | 0      | 1       | 47    | 48    | ❗     |
| Create               | 23     | 0      | 2       | 23    | 25    | ❗     |
| Verify               | 12     | 0      | 1       | 12    | 13    | ❗     |
| Manage               | 37     | 0      | 2       | 39    | 39    | ❗     |
| Package              | 0      | 0      | 1       | 0     | 1     | ➖     |
| Secure               | 2      | 0      | 0       | 2     | 2     | ❗     |
| Configure            | 0      | 0      | 1       | 0     | 1     | ➖     |
| Protect              | 2      | 0      | 0       | 2     | 2     | ❗     |
| Version sanity check | 0      | 0      | 1       | 0     | 1     | ➖     |
+----------------------+--------+--------+---------+-------+-------+--------+
| Total                | 123    | 0      | 9       | 125   | 132   | ❗     |
+----------------------+--------+--------+---------+-------+-------+--------+

Setting label groupacquisition based on @nicolasdular's group.

added groupacquisition label

changed milestone to %15.2

added devopsgrowth sectiongrowth labels

assigned to @nicolasdular

marked this merge request as ready

added 1165 commits

85e9670c...59a17eaf - 1164 commits from branch master
131bf491 - Refactor Members ActivateService

Compare with previous version

added backend label

changed the description

removed backend label

added typemaintenance label

resolved all threads

added 1 commit

5e1602df - Refactor Members ActivateService

Compare with previous version

added backend label

Hey Hey @rkadam3 Do you mind performing a backend review for this merge request, please? :) I know it's a larger MR but most of the changes are related to changing the tests. I tried to document everything as good as possible to make sense of it.

Thanks!

requested review from @rkadam3

approved this merge request

removed review request for @rkadam3

@rkadam3, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

added 1 commit

15c8bec6 - Refactor Members ActivateService

Compare with previous version

added 1 commit

d99ad9ed - Refactor Members ActivateService

Compare with previous version

added 1 commit

227ef260 - Refactor Members ActivateService

Compare with previous version

Hey @dstull Would you mind to take over the maintainer review as you have context around Members and looked at this code before already? No rush - I know it's a larger MR and I am sorry for that. I have no idea how to split it up as most of the refactoring affects test.