Fetch runner counts with renderless components

What does this MR do and why?

This change refactors a complicated smart query factory by using a renderless components.

This solution makes use a of a simpler renderless component that fetches a total count of runners given arbitrary filters, so the component can be reused in different layouts.

Why this change?

While working on #339523 (closed) we will need to use different queries in CE and GitLab Ultimate. So it became necessary to group the complexity of the smart queries in a single place, so we could reuse the counts in EE as a component that can be imported separately.

Work in progress: !91905 (merged)

Screenshots or screen recordings

No user-facing changes are expected, but these are the related components:

How to set up and validate locally

No user-facing changes are expected. To verify, visit either:

1. The Admin -> Runners section e.g. http://gdk.test:3000/admin/runners
2. A Group -> CI/CD -> Runners section http://gdk.test:3000/groups/h5bp/-/runners

And verify the runner total counts are accurate, with and without filters.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Related to #339523 (closed)

changed milestone to %15.2

added FY23Q2 GitLab Ultimate OKR-FY24Q2 Technical Writing UI text UX UX scorecard-rec [Deprecated] Category:Runner [Deprecated] Category:Runner Fleet auto updated devopsverify direction featureenhancement grouprunner sectionops severity1 typefeature workflowin dev + 1 deleted label

Suggested Reviewers (beta)

The individuals below may be good candidates to participate in the review based on various factors.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Suggested Reviewers
@reprazent, @peterhegman, @cwiesner, @justin_ho, @gdoyle

If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

added 1 commit

• f0705eec - Refactor multiple smart queries in runner counts

Compare with previous version

added frontend label

	2 Warnings
	This merge request is quite big (1165 lines changed), please consider splitting it into multiple merge requests.
	featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart. For more information, see: The Handbook page on merge request types. The definition of done documentation.

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Janis Altherr (@janis) (UTC+2, same timezone as @mrincon)	David O'Regan (@oregand) (UTC+1, 1 hour behind @mrincon)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits d708c712 and dd35738d

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	3.53 MB	3.53 MB	-	-0.0 %
mainChunk	1.96 MB	1.96 MB	-	0.0 %

Significant Reduction: 1

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.projects.work_items	1.35 MB	974.8 KB	-403 KB	-29.2 %

---

Note: We do not have exact data for d708c712. So we have used data from: 8da334e0.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

added 1 commit

• e951f9da - Refactor multiple smart queries in runner counts

Compare with previous version

Allure report

allure-report-publisher generated test report!

review-qa-blocking: test report for dd35738d

expand test summary

+---------------------------------------------------------------------------+
|                              suites summary                               |
+----------------------+--------+--------+---------+-------+-------+--------+
|                      | passed | failed | skipped | flaky | total | result |
+----------------------+--------+--------+---------+-------+-------+--------+
| Plan                 | 47     | 0      | 1       | 47    | 48    | ❗     |
| Create               | 23     | 0      | 2       | 23    | 25    | ❗     |
| Protect              | 2      | 0      | 0       | 2     | 2     | ❗     |
| Package              | 0      | 0      | 1       | 0     | 1     | ➖     |
| Manage               | 37     | 0      | 2       | 39    | 39    | ❗     |
| Verify               | 12     | 0      | 1       | 12    | 13    | ❗     |
| Version sanity check | 0      | 0      | 1       | 0     | 1     | ➖     |
| Secure               | 2      | 0      | 0       | 2     | 2     | ❗     |
| Configure            | 0      | 0      | 1       | 0     | 1     | ➖     |
+----------------------+--------+--------+---------+-------+-------+--------+
| Total                | 123    | 0      | 9       | 125   | 132   | ❗     |
+----------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

• c2cb8151 - Refactor multiple smart queries in runner counts

Compare with previous version

removed OKR-FY24Q2 label

removed GitLab Ultimate label

added 1 commit

• 958db6c5 - Refactor multiple smart queries in runner counts

Compare with previous version

removed Technical Writing label

removed UI text label

added 1 commit

• f745f9f6 - Refactor multiple smart queries in runner counts

Compare with previous version

added 317 commits

• f745f9f6...0538bd4d - 316 commits from branch master
• b4892278 - Refactor multiple smart queries in runner counts

Compare with previous version

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

marked this merge request as ready

changed title from Draft: Refactor multiple smart queries in runner counts to Refactor multiple smart queries into renderless components to fetch runner counts

added 1 commit

• 70dacb05 - Refactor smart queries to fetch runner counts

Compare with previous version

added 1 commit

• f946dadb - Refactor smart queries to fetch runner counts

Compare with previous version

changed the description

removed UX label

@snachnolkar Can you help me with an initial review? Feel free to pass to our maintainer once this MR happens to pass your review.

requested review from @snachnolkar

changed title from Refactor multiple smart queries into renderless components to fetch runner counts to Fetch runner counts with renderless components

assigned to @mrincon

approved this merge request

requested review from @f_caplette and removed review request for @snachnolkar

@snachnolkar, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

requested review from @xanf

removed review request for @f_caplette

added 1 commit

• dd35738d - Refactor smart queries to fetch runner counts

Compare with previous version

changed the description

mentioned in merge request !91905 (merged)

requested review from @jivanvl and removed review request for @xanf

resolved all threads

approved this merge request

Looks good to me! This is a great refactor

enabled an automatic merge when the pipeline for 556d11a0 succeeds

merged

mentioned in commit b67a0ac1

added workflowstaging-canary label and removed workflowin dev label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowstaging label and removed workflowproduction label

added workflowpost-deploy-db-staging label and removed workflowstaging label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label