Refactor `Project :: Infra :: Google Cloud` Routing

Sri Rangrequested to merge
incubation-cloud-seed-refactor-split-tabs into master

Disclaimer: It's smaller than it appears. Yes, yes, twss. Please read on for an explanation!

What does this MR do and why?

This is regarding the organization and setup of Project :: Infrastructure :: Google Cloud section. Zero new features are being introduced. Instead this MR refactors and fixes trivial bugs / gotchas along the way.

Half the routing happens in Rails, the other half happens in Vue. This is not desirable. This MR moves all the routing responsibilities to Rails. Let Vue components just be good ol' Vue components doing what they were built for. Let's not introduce any hacks -- rather use standard Rails views, entry point index.js files and dumb Vue components that are unaware and unburdened with routing responsibilities.

Ditto for error messages. Rails has a perfectly good Flash messaging capabilities. So why did I try to invent my own? Bad Sri. Discard gcp_error components and use standard Rails error management capabilities.

The only new code that's introduced is a google-cloud-menu component -- because, sadly, gl-tabs doesn't support tab being traditional links. Thus, keeping up with the spirit of no UI changes, introduce a tab-like component that routes the users with Real Links(tm).

Things removed

  • assets/javascripts/google_cloud/components/errors/gcp_error.vue
  • assets/javascripts/google_cloud/components/errors/no_gcp_projects.vue
  • assets/javascripts/google_cloud/components/app.vue
  • assets/javascripts/google_cloud/components/home.vue
  • controllers/projects/google_cloud_controller.rb

Things moved

  • assets/javascripts/google_cloud/databases/cloudsql/create_instance_form.vue
  • assets/javascripts/google_cloud/databases/cloudsql/instance_table.vue
  • assets/javascripts/google_cloud/databases/service_table.vue
  • assets/javascripts/google_cloud/deployments/service_table.vue
  • assets/javascripts/google_cloud/gcp_regions/form.vue
  • assets/javascripts/google_cloud/gcp_regions/list.vue
  • assets/javascripts/google_cloud/service_accounts/form.vue
  • assets/javascripts/google_cloud/service_accounts/list.vue

Things added

  • assets/javascripts/google_cloud/components/google_cloud_menu.vue
  • assets/javascripts/google_cloud/databases/index.js
  • assets/javascripts/google_cloud/databases/panel.vue
  • assets/javascripts/google_cloud/deployments/index.js
  • assets/javascripts/google_cloud/deployments/panel.vue
  • assets/javascripts/google_cloud/service_accounts/index.js
  • controllers/projects/google_cloud/configuration_controller.rb
  • controllers/projects/google_cloud/databases_controller.rb

Everything else

  • Updated references
  • Added namespaces for i18n
  • Consistent test labels in specs
  • Entry point js and haml files

Screenshots or screen recordings

None, purely code changes. Nothing visual.

How to set up and validate locally

  1. Setup GDK for Google OAuth2: https://docs.gitlab.com/ee/integration/google.html
  2. Enable the incubation_5mp_google_cloud feature flag.
  3. Visit Project :: Infra :: Google Cloud section.
  4. Verify that Configuration, Deployments and Databases are server rendered routes.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sri Rang

Merge request reports