Migrate `form_errors` in milestones/_form.html.haml to Pajamas alert
What does this MR do and why?
Migrate form_errors
in app/views/projects/milestones/_form.html.haml to Pajamas::AlertComponent.
Screenshots or screen recordings
Scenario | Screenshot |
---|---|
Before | ![]() |
After | ![]() |
How to set up and validate locally
- On your local GDK, go to any project eg. http://localhost:3000/flightjs/Flight
- From the left menu bar, go to
Issues -> Milestones
. - Click on
New milestone
button. - Create a milestone such that
Due date
is beforeStart date
. - Observe that alert is shown.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #364886 (closed)
Merge request reports
Activity
changed milestone to %15.2
assigned to @snachnolkar
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@filipa
,@rymai
,@godfat
,@smcgivern
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- A deleted user
added backend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Thomas Hutterer ( @thutterer
) (UTC+2, 3.5 hours behind@snachnolkar
)Alex Pooley ( @alexpooley
) (UTC+8, 2.5 hours ahead of@snachnolkar
)frontend Samantha Ming ( @sming-gitlab
) (UTC+2, 3.5 hours behind@snachnolkar
)Florie Guibert ( @fguibert
) (UTC+10, 4.5 hours ahead of@snachnolkar
)test for spec/features/*
Sean Gregory ( @sgregory2
) (UTC-4, 9.5 hours behind@snachnolkar
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for f2f5f710expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Manage | 37 | 0 | 2 | 39 | 39 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 123 | 0 | 9 | 125 | 132 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
package-and-qa:
test report for f2f5f710expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 918 | 9 | 38 | 7 | 965 | ❌ | | Manage | 655 | 3 | 18 | 9 | 676 | ❌ | | Secure | 126 | 0 | 12 | 2 | 138 | ❗ | | Protect | 12 | 0 | 0 | 0 | 12 | ✅ | | Plan | 320 | 12 | 0 | 0 | 332 | ❌ | | Verify | 236 | 6 | 18 | 0 | 260 | ❌ | | Release | 35 | 1 | 0 | 0 | 36 | ❌ | | Version sanity check | 0 | 0 | 6 | 3 | 6 | ➖ | | Fulfillment | 14 | 0 | 67 | 0 | 81 | ✅ | | Configure | 1 | 0 | 18 | 0 | 19 | ✅ | | Package | 144 | 0 | 21 | 12 | 165 | ❗ | | Product Intelligence | 13 | 0 | 0 | 0 | 13 | ✅ | | Enablement:Search | 9 | 0 | 1 | 0 | 10 | ✅ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 2483 | 31 | 199 | 33 | 2713 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Florie Guibert
@lmeckley
Could you please review frontend for this MR?
Although review roulette has suggested a backend review, I don't think we need one here.
requested review from @lmeckley and @sgregory2
- Resolved by Florie Guibert
@sgregory2
Could you please review the test for this MR?
added workflowin review label and removed workflowin dev label
- The
gitlab-qa-mirror
downstream pipeline for !91652 (f2f5f710) failed!
- The
@sgregory2
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links: