Skip to content

Fix deprecation: Passing an argument to force an association to reload is now deprecated

Jasper Maes requested to merge jlemaes/gitlab-ee:deprecated-passing-argument-to-association into master

What does this MR do?

EE version of gitlab-org/gitlab-ce!24136

Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_import_data` instead. (called from block (4 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/controllers/projects/mirrors_controller_spec.rb:162)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload` on the result collection proxy instead. (called from block (5 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/requests/api/variables_spec.rb:18)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_push_rule` instead. (called from block (3 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/controllers/projects/push_rules_controller_spec.rb:22)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_import_data` instead. (called from block (4 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/controllers/projects/mirrors_controller_spec.rb:170)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_import_data` instead. (called from block (4 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/controllers/projects/mirrors_controller_spec.rb:182)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload` on the result collection proxy instead. (called from reset_approval_cache! at /builds/gitlab-org/gitlab-ee/ee/app/models/concerns/visible_approvable.rb:79)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_push_rule` instead. (called from block (7 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/controllers/projects/push_rules_controller_spec.rb:58)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_push_rule` instead. (called from block (6 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/controllers/projects/push_rules_controller_spec.rb:83)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_index_status` instead. (called from update_index_status at /builds/gitlab-org/gitlab-ee/ee/lib/gitlab/elastic/indexer.rb:92)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_push_rule` instead. (called from block (6 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/controllers/projects/push_rules_controller_spec.rb:45)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload` on the result collection proxy instead. (called from block (5 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/requests/api/variables_spec.rb:31)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_push_rule` instead. (called from block (7 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/controllers/projects/push_rules_controller_spec.rb:70)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_push_rule` instead. (called from block (3 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/models/project_spec.rb:243)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload` on the result collection proxy instead. (called from reset_approval_cache! at /builds/gitlab-org/gitlab-ee/ee/app/models/concerns/visible_approvable.rb:78)
Passing an argument to force an association to reload is now deprecated and will be removed in Rails 5.1. Please call `reload_import_data` instead. (called from block (3 levels) in <top (required)> at /builds/gitlab-org/gitlab-ee/ee/spec/features/projects/mirror_spec.rb:57)

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Merge request reports