Skip to content

Correct check of epic_color_highlight FF in Epic mutations

Andrew Smith requested to merge espadav8/gitlab:7641-correct-feature-flag-checking-for-epic-color-mutations into master

What does this MR do and why?

The validation for the Epic color attribute was attempting to check the feature flag status without passing in the group object to check the feature flag against causing the attribute to always be removed unless the feature flag was enabled globally.

The removal of the color attribute also happened at the wrong time. The color attribute should be removed if the flag isn't enabled before checking args.empty?.

How to set up and validate locally

  1. Enable epic_color_highlight feature flag for the flightjs group
  2. Attempt to create a new Epic
    • Should see the colour dropdown
  3. Select a colour other than Blue
  4. After saving the Epic notice that the Epic colour is still Blue
  5. Attempt to change the colour in the sidebar, colour will remain Blue

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #7641 (closed)

Edited by Andrew Smith

Merge request reports