Correct check of epic_color_highlight FF in Epic mutations
What does this MR do and why?
The validation for the Epic color
attribute was attempting to check
the feature flag status without passing in the group object to check the
feature flag against causing the attribute to always be removed unless
the feature flag was enabled globally.
The removal of the color
attribute also happened at the wrong time.
The color
attribute should be removed if the flag isn't enabled before
checking args.empty?
.
How to set up and validate locally
- Enable
epic_color_highlight
feature flag for theflightjs
group - Attempt to create a new Epic
- Should see the colour dropdown
- Select a colour other than
Blue
- After saving the Epic notice that the Epic colour is still
Blue
- Attempt to change the colour in the sidebar, colour will remain
Blue
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #7641 (closed)
Merge request reports
Activity
added typefeature label
Hey @espadav8!
Thank you for your contribution to GitLab. Please refer to the contribution flow documentation for a quick overview of the process, and the merge request (MR) guidelines for the detailed process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help moving the MR forward, feel free to post
@gitlab-bot help
. Read more on how to get help.To enable automated checks on your MR, please configure Danger for your fork.
You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @espadav8
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Serena Fang ( @serenafang
) (UTC-5)Matthias Käppler ( @mkaeppler
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangeradded 1 commit
- a1e91558 - Correct validate epic_color_highlight FF in Epic mutations
- Resolved by Matthias Käppler
@gitlab-bot ready @serenafang
Hi @serenafang
Would you mind giving this MR an initial review for me please? The description gives most of the information, but a TL;DR is that I introduced a new property to Epics and hid them behind a feature flag. That flag was updated to allow it to be enabled on a per-group basis, but in the MR that did the change, the mutations were missed. This MR updates the mutations to also support the feature flag to be enabled on a per-group basis. (it also fixes an issue where the attribute was being removed at the wrong time
)Let me know if you have any questions, or if this looks wrong to you. Thanks
Edited by Andrew Smith
added workflowready for review label and removed workflowin dev label
requested review from @serenafang
@serenafang, this Community contribution is ready for another review! Please assign other reviewer(s) if you do not have availability.
Please add the workflowin dev label if the merge request needs actions from the author.
added sectiondev label
- Resolved by Matthias Käppler
@serenafang
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
removed review request for @serenafang
requested review from @mkaeppler
added typemaintenance label and removed typefeature label
changed milestone to %15.2
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @dzaporozhets
,@jprovaznik
,@DylanGriffith
,@allison.browne
,@alexkalderimis
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Diogo Frazão ( @dfrazao-gitlab
) (UTC+2)Mayra Cabrera ( @mayra-cabrera
) (UTC-5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerenabled an automatic merge when the pipeline for 464d940d succeeds
mentioned in commit ffddfc3c
@espadav8, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
- Leave a
@gitlab-bot feedback Great. Thanks for getting colourful epic closer to release
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue #365336 (closed)