Skip to content

Resolve "Notebook Diff being displayed twice"

Eduardo Bonet requested to merge 364531-notebook-diff-being-displayed-twice-2 into master

What does this MR do and why?

On commit page, after clicking "Expand Files" on for .ipynb, we were displaying the semantic notebook diff twice instead of the original and semantic diffs

How to set up and validate locally

Example below:

  1. Open a commit with a collapsed notebook diff (eg gitlab-test@9fd7ad70)

  2. Click "Click to expand it"

  3. Without the changes, not that the semantic diff is displayed twice, and the buttons to swap between semantic and raw diff don't work as expected

    91376_wrong

  4. With the changes, upon clicking the semantic diff is displayed, and we are able to swap between the viewer modes

    91376_correct

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #364531 (closed)

Edited by Eduardo Bonet

Merge request reports