Skip to content

Collapsed Ipynb diffs not loading in MRs

Eduardo Bonet requested to merge 361750-ipynb-diffs-not-being-generated-for-mrs-2 into master

Does not generate ipynb diff if file is collapsed

Ipynb diffs would still be generated when the file was collapsed, which would cause MRs to not be able to load the diff when clicking "Load Anyway"

How to set up and validate locally

  1. Open an MR that contais an ipynb that is too large to render by default (eg gitlab-test!56 (diffs))

  2. Without changes, when clicking "Expand File" a button to download the file is shown image

    • Click on "Expand File": image

  3. Apply changes and create a new MR

  4. Click "Expand File" triggers a request that loads the MR image

    • Click on "Expand File": image

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #361750 (closed)

Edited by Eduardo Bonet

Merge request reports