Migrate `form_errors` in _repository_check.html.haml to Pajamas alert
What does this MR do and why?
Migrate form_errors
in app/views/admin/application_settings/_repository_check.html.haml to Pajamas::AlertComponent.
Screenshots or screen recordings
Scenario | Screenshot |
---|---|
Before | ![]() |
After | ![]() |
How to set up and validate locally
- Login as admin in your local GDK.
- Go to
Settings -> Repository
from the left menu - Expand the
Repository maintenance
section. (http://localhost:3000/admin/application_settings/repository#js-repository-check-settings) - Enter negative values in all the 3 number fields.
- Click on
Save changes
. - Observe that alert is shown.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #364916 (closed)
Merge request reports
Activity
changed milestone to %15.2
added OKR-FY24Q2 component:alert frontend groupsubscription management pajamasintegrate sectiondev severity4 typemaintenance workflowin dev + 1 deleted label
assigned to @snachnolkar
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@jivanvl
,@stanhu
,@kushalpandya
,@allison.browne
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, same timezone as@snachnolkar
)Stan Hu ( @stanhu
) (UTC-7, 12.5 hours behind@snachnolkar
)frontend Tomáš Bulva ( @tbulva
) (UTC+2, 3.5 hours behind@snachnolkar
)Miguel Rincon ( @mrincon
) (UTC+2, 3.5 hours behind@snachnolkar
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @harsimarsandhu
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for cfb57c27expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Manage | 37 | 0 | 2 | 39 | 39 | ❗ | | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 124 | 0 | 9 | 126 | 133 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Simon Knox
@snachnolkar This is a frontend change and I'm a backend reviewer, You might want to pick someone from frontend reviewers
, So i am removing myself from reviewer.
removed review request for @harsimarsandhu
requested review from @tristan.read
- Resolved by Simon Knox
@tristan.read
Could you please review this MR?
added workflowin review label and removed workflowin dev label
requested review from @psimyn and removed review request for @tristan.read
@tristan.read
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links: