Collapse Edit lock form when clicked outside sidebar in issues
What does this MR do and why?
Fixes this bug #19409 (closed). Collapse the Lock Edit form on clicking anywhere else in the sidebar when viewing issue detail page
Screenshots or screen recordings
Screen_Recording_2022-06-27_at_4.46.40_PM
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Example below:
- Open any issue detail page in logged in status for eg:
http://127.0.0.1:3000/gitlab-instance-3485f007/Monitoring/-/issues/20
- Click the
Edit
button next toLock issue
Label in sidebar . - Try to click outside anywhere , the lock form should be closed
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #19409 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @deepika.guliani
@deepika.guliani I see this has already merged and just checked it out — looks great! In the future just make sure to add the suggested UX reviewer (me, in this case) as part of the review process. Adding the UX tag here was a good start and the outcome works well
Hey @nickleonard ! This is definitely a miss from my side. Since this was one of my first MR's to be merged ( actually 2nd after the team info update ), I had little clue about the process. After Natalia pointed out in one of the other MR's for UX review , I got to know.
Thanks for looking into it
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @cngo
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @iamphill
,@kushalpandya
,@jerasmus
,@aqualls
,@peterhegman
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botremoved review request for @cngo
- A deleted user
added typebug label
2 Warnings 91e35e53: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Samantha Ming ( @sming-gitlab
) (UTC+2)Florie Guibert ( @fguibert
) (UTC+10)UX Nick Leonard ( @nickleonard
) (UTC-5)Amelia Bauerly ( @ameliabauerly
) (UTC-7)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1b3dbe97 and 0a36d8d9
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.54 MB 3.54 MB - 0.0 % mainChunk 1.98 MB 1.98 MB - 0.0 % Significant Growth: 2Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.releases.edit 1.56 MB 1.61 MB +55.24 KB 3.5 % pages.projects.releases.new 1.56 MB 1.61 MB +55.24 KB 3.5 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for 1b3dbe97. So we have used data from: 2e888a8a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 0a36d8d9expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Manage | 37 | 0 | 2 | 37 | 39 | ❗ | | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 124 | 0 | 9 | 124 | 133 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
removed [deprecated] Accepting merge requests label
requested review from @cngo
- Resolved by Simon Knox
@cngo The only one thing which I would have liked to do differently here is create a different block maybe so that lock form is already open in the beforeEach ! Since there was only one test case I thought of adding it in the same block , maybe I can add another test case to click on a random other element on the page in the sidebar ?
I will try no to repeat the same MR feedbacks in the coming MR's ! ( maybe because I created this before reading the first one's comments ).
Thank you !
removed review request for @cngo
@cngo
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
added 1 commit
- c2e5acc7 - Collapse Edit lock form when clicked outside sidebar in issues
- Resolved by Simon Knox
- Resolved by Simon Knox
@deepika.guliani This works great
I left a minor suggestion on tests and I second Simon's suggestion to use
GlOutsideDirective
added 833 commits
-
c2e5acc7...1b3dbe97 - 831 commits from branch
master
- 91e35e53 - Collapse Edit lock form when clicked outside sidebar in issues
- 0a36d8d9 - Use GlOutsideDirective for closing the form when clicked outside
-
c2e5acc7...1b3dbe97 - 831 commits from branch
@psimyn Can you please review after I made the changes and created a new issue for the follow up of the test case ? Thanks !
@psimyn, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
mentioned in commit e1ae21c7
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)