Skip to content
Snippets Groups Projects

Collapse Edit lock form when clicked outside sidebar in issues

1 unresolved thread

What does this MR do and why?

Fixes this bug #19409 (closed). Collapse the Lock Edit form on clicking anywhere else in the sidebar when viewing issue detail page

Screenshots or screen recordings

Screen_Recording_2022-06-27_at_4.46.40_PM

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Example below:

  1. Open any issue detail page in logged in status for eg: http://127.0.0.1:3000/gitlab-instance-3485f007/Monitoring/-/issues/20
  2. Click the Edit button next to Lock issue Label in sidebar .
  3. Try to click outside anywhere , the lock form should be closed

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #19409 (closed)

Edited by Deepika Guliani

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Florie Guibert
  • @deepika.guliani This works great :thumbsup:

    I left a minor suggestion on tests and I second Simon's suggestion to use GlOutsideDirective

  • Deepika Guliani added 833 commits

    added 833 commits

    • c2e5acc7...1b3dbe97 - 831 commits from branch master
    • 91e35e53 - Collapse Edit lock form when clicked outside sidebar in issues
    • 0a36d8d9 - Use GlOutsideDirective for closing the form when clicked outside

    Compare with previous version

  • @psimyn Can you please review after I made the changes and created a new issue for the follow up of the test case ? Thanks !

  • Simon Knox approved this merge request

    approved this merge request

  • Simon Knox resolved all threads

    resolved all threads

  • merged

  • @psimyn, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to merge when pipeline succeeds.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    (Improve this message?)

  • Simon Knox mentioned in commit e1ae21c7

    mentioned in commit e1ae21c7

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading