Show epic colour highlight on Epic boards
What does this MR do and why?
Blocked until !90975 (merged) has been merged
Adds the epic colour highlight to epics cards on the epic boards.
Screenshots or screen recordings
FF off (existing) | FF on |
---|---|
![]() |
![]() |
How to set up and validate locally
- Enable
epic_color_highlight
feature flag (Feature.enable(:epic_color_highlight)
) - Create/update some Epics to use some colours
- Visit the epic board
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #7641 (closed)
Merge request reports
Activity
added typefeature label
mentioned in merge request !90975 (merged)
@gitlab-bot ready @uhlexsis @kushalpandya @mushakov
Opening this a little early since it requires Remove GraphQL check for feature flag and retur... (!90975 - merged) to be merged first.
This is to show how the epic colours will be used on the epic boards. This might help with coming up with some language to add into the tooltip/help text in !90821 (merged).
2 Warnings d6f421eb: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Erick Bajao ( @iamricecake
) (UTC+8)Pavel Shutsin ( @pshutsin
) (UTC+2)frontend Minahil Nichols ( @minahilnichols
) (UTC-4)Mike Greiling ( @mikegreiling
) (UTC-5)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Andrew Smithadded Community contribution label
added 23 commits
-
132d8639...b69f437f - 21 commits from branch
gitlab-org:master
- 20c4e972 - Remove GraphQL check for feature flag and return null
- 4866a027 - Show epic colours on epic boards
-
132d8639...b69f437f - 21 commits from branch
mentioned in issue gitlab-org/quality/triage-reports#8133 (closed)
added 77 commits
-
4866a027...a7e5bdfa - 75 commits from branch
gitlab-org:master
- 29b45b3a - Remove GraphQL check for feature flag and return null
- a80f106f - Show epic colours on epic boards
-
4866a027...a7e5bdfa - 75 commits from branch
added Category:Portfolio Management devopsplan groupproduct planning labels
added 214 commits
-
a80f106f...94eebfc0 - 212 commits from branch
gitlab-org:master
- 8a3f4c32 - Remove GraphQL check for feature flag and return null
- 8119d4ee - Show epic colours on epic boards
-
a80f106f...94eebfc0 - 212 commits from branch
added 114 commits
-
8119d4ee...5628a281 - 113 commits from branch
gitlab-org:master
- b9306281 - Show epic colours on epic boards
-
8119d4ee...5628a281 - 113 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Florie Guibert
@gitlab-bot ready @uhlexsis @mushakov
I believe this MR is ready for a review now @uhlexsis. With the feature flag off I've set the side colour to be the default
blue-600
which is also used on the roadmap page. I'm not sure if you want any colours on the board yet though, until the feature flag is enabled for everyone. It would be easy to change the side colour to be a grey instead, or if you'd rather no UI changes at all when the flag is disabled, I could look at changing the MR and introduce a.colourful
class or something to the.board-card
elements that is only applied when the flag is on and move the new styling into there. Let me know what you'd prefer
added workflowready for review label
@uhlexsis @mushakov, this Community contribution is ready for another review! Please assign other reviewer(s) if you do not have availability.
Please add the workflowin dev label if the merge request needs actions from the author.
added 20 commits
-
1cfdd634...d6c863e3 - 18 commits from branch
gitlab-org:master
- 03de471c - Show epic colours on epic boards
- e2471d77 - Duplicate list epic query to work with previous GraphQL implementation
-
1cfdd634...d6c863e3 - 18 commits from branch
assigned to @espadav8
added sectiondev label
removed review request for @uhlexsis
added UX label
added 702 commits
-
e2471d77...cc754381 - 700 commits from branch
gitlab-org:master
- 89691e65 - Show epic colours on epic boards
- 7ed928e2 - Duplicate list epic query to work with previous GraphQL implementation
-
e2471d77...cc754381 - 700 commits from branch
mentioned in issue #366809 (closed)
- Resolved by Florie Guibert
@gitlab-bot ready
Hi @thutterer and @sming-gitlab
Would you mind giving this a backend and frontend review for me please.
This is continuing some work based on an initial mockup design by
@uhlexsis
in Figma - #7641 (comment 754097112)Let me know if there is anything you need from me :)
- Resolved by Andrew Smith
requested review from @danmh
- Resolved by Florie Guibert
@thutterer
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
- Resolved by Andrew Smith
- Resolved by Andrew Smith
- Resolved by Samantha Ming
added 1 commit
- 97042777 - Duplicate list epic query to work with previous GraphQL implementation
mentioned in issue danmh/danmh#7 (closed)
added 1 commit
- 0a9f226a - Duplicate list epic query to work with previous GraphQL implementation
- Resolved by Andrew Smith
added 140 commits
-
0a9f226a...d32c00b1 - 138 commits from branch
gitlab-org:master
- cd70a86c - Show epic colours on epic boards
- c55572d7 - Duplicate list epic query to work with previous GraphQL implementation
-
0a9f226a...d32c00b1 - 138 commits from branch
requested review from @fguibert
mentioned in issue #367022 (closed)
mentioned in issue gl-retrospectives/ux-retrospectives#53 (closed)
mentioned in merge request !91879 (merged)