Migrate form errors for new groups registration
What does this MR do and why?
Migrate to form alerts to Pajamas
Related to #364953 (closed)
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Run your GitLab instance as SaaS (use
GITLAB_SIMULATE_SASS=1
) - Open http://localhost:3000/users/sign_up/groups/new
- Choose the same name for the group as one of already existing
- Observe the errors
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @dzubova
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @dbalexandre
,@tkuah
,@nick.thomas
,@mayra-cabrera
,@afontaine
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Valery Sizov ( @vsizov
) (UTC+1, 1 hour behind@dzubova
)Douglas Barbosa Alexandre ( @dbalexandre
) (UTC-3, 5 hours behind@dzubova
)frontend Sharmad Nachnolkar ( @snachnolkar
) (UTC+5.5, 3.5 hours ahead of@dzubova
)David O'Regan ( @oregand
) (UTC+1, 1 hour behind@dzubova
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
@dzubova - please add typebug typefeature, typemaintenance or a subtype label to this merge request.- typebug: Defects in shipped code and fixes for those defects. This includes all the bug types (availability, performance, security vulnerability, mobile, etc.)
- typefeature: Effort to deliver new features, feature changes & improvements. This includes all changes as part of new product requirements like application limits.
- typemaintenance: Up-keeping efforts & catch-up corrective improvements that are not Features nor Bugs. This includes restructuring for long-term maintainability, stability, reducing technical debt, improving the contributor experience, or upgrading dependencies.
See the handbook for more guidance on classifying.
This message was created with automation and Engineering Productivity is looking for feedback in this issue:
https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues/43
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 59fd47baexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Create | 23 | 0 | 2 | 22 | 25 | ❗ | | Manage | 37 | 0 | 2 | 38 | 39 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Secure | 4 | 0 | 0 | 4 | 4 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 126 | 0 | 9 | 126 | 135 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
added typemaintenance label
added OKR-FY24Q2 component:alert frontend groupsubscription management pajamasintegrate sectiondev severity4 + 1 deleted label
changed milestone to %15.2
- Resolved by David O'Regan
@tyleramos could you please review the MR? ( I think it's enough if we have only one backend review for this tiny change)
@slashmanov could you please do a frontend review for this MR?
@tyleramos
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @oregand
added 111 commits
-
ba8824fe...107b4ff3 - 110 commits from branch
master
- 14cbb0d0 - Migrate form errors
-
ba8824fe...107b4ff3 - 110 commits from branch
added 39 commits
-
14cbb0d0...7056a043 - 38 commits from branch
master
- 59fd47ba - Migrate form errors
-
14cbb0d0...7056a043 - 38 commits from branch
added workflowin review label
enabled an automatic merge when the pipeline for ae4f992b succeeds
mentioned in commit 1765db36
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)
added devopsmanage label and removed 1 deleted label