Skip to content
Snippets Groups Projects

Resolve "Reset attempts before we execute the batched background Migration inline"

All threads resolved!

What does this MR do and why?

If we have a job with the number max of attempts (3) reached, we cannot finalize the batched background migration because we don't process these jobs.

In this MR, we are resetting the number of attempts for jobs that reached the max number of attempts before we start to execute the batched background migration inline.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #366169 (closed)

Edited by Diogo Frazão

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Diogo Frazão marked this merge request as ready

    marked this merge request as ready

  • Amparo Luna
  • Amparo Luna
  • Amparo Luna
  • Diogo Frazão added 1 commit

    added 1 commit

    Compare with previous version

  • Amparo Luna removed review request for @a_luna

    removed review request for @a_luna

  • Diogo Frazão added 1 commit

    added 1 commit

    • 40fc9e45 - Mock function to return the batched background migration

    Compare with previous version

  • Diogo Frazão requested review from @jschafer

    requested review from @jschafer

  • Igor Drozdov requested review from @krasio and removed review request for @igor.drozdov

    requested review from @krasio and removed review request for @igor.drozdov

  • Igor Drozdov approved this merge request

    approved this merge request

  • :wave: @igor.drozdov, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Jonathan Schafer removed review request for @jschafer

    removed review request for @jschafer

  • Krasimir Angelov
  • Diogo Frazão added 1 commit

    added 1 commit

    Compare with previous version

  • Diogo Frazão added 1 commit

    added 1 commit

    Compare with previous version

  • Diogo Frazão added 1 commit

    added 1 commit

    Compare with previous version

  • Krasimir Angelov removed review request for @krasio

    removed review request for @krasio

  • Diogo Frazão requested review from @jschafer

    requested review from @jschafer

  • Diogo Frazão requested review from @krasio

    requested review from @krasio

  • Diogo Frazão added 1170 commits

    added 1170 commits

    Compare with previous version

  • A deleted user added database label

    added database label

  • Krasimir Angelov approved this merge request

    approved this merge request

  • added databaseapproved label and removed databaseactive label

  • Krasimir Angelov removed review request for @krasio

    removed review request for @krasio

  • Jonathan Schafer approved this merge request

    approved this merge request

  • Jonathan Schafer requested review from @eurie and removed review request for @jschafer

    requested review from @eurie and removed review request for @jschafer

  • Ethan Urie
  • Ethan Urie removed review request for @eurie

    removed review request for @eurie

  • Diogo Frazão added 1 commit

    added 1 commit

    • f6c4044c - Use BatchedJob::MAX_ATTEMPTS to define max_attempts

    Compare with previous version

  • Diogo Frazão requested review from @eurie

    requested review from @eurie

  • Ethan Urie resolved all threads

    resolved all threads

  • Ethan Urie approved this merge request

    approved this merge request

  • Ethan Urie enabled an automatic merge when the pipeline for 62c6c467 succeeds

    enabled an automatic merge when the pipeline for 62c6c467 succeeds

  • merged

  • Ethan Urie mentioned in commit ef8e39a2

    mentioned in commit ef8e39a2

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #360377 (closed)

  • Please register or sign in to reply
    Loading