Resolve "Reset attempts before we execute the batched background Migration inline"
What does this MR do and why?
If we have a job with the number max of attempts (3) reached, we cannot finalize the batched background migration because we don't process these jobs.
In this MR, we are resetting the number of attempts for jobs that reached the max number of attempts before we start to execute the batched background migration inline.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #366169 (closed)
Merge request reports
Activity
changed milestone to %15.2
assigned to @dfrazao-gitlab
requested review from @krasio
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @dbalexandre
,@mayra-cabrera
,@engwan
,@tigerwnz
,@acroitor
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot2 Warnings 6ec9d42d: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, 3.5 hours ahead of@dfrazao-gitlab
)Tetiana Chupryna ( @brytannia
) (UTC+2, same timezone as@dfrazao-gitlab
)database Dylan Griffith ( @DylanGriffith
) (UTC+10, 8 hours ahead of@dfrazao-gitlab
)Steve Abrams ( @sabrams
) (UTC-6, 8 hours behind@dfrazao-gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by 🤖 GitLab Bot 🤖
@dfrazao-gitlab - please add typebug typefeature, typemaintenance or a subtype label to this merge request.- typebug: Defects in shipped code and fixes for those defects. This includes all the bug types (availability, performance, security vulnerability, mobile, etc.)
- typefeature: Effort to deliver new features, feature changes & improvements. This includes all changes as part of new product requirements like application limits.
- typemaintenance: Up-keeping efforts & catch-up corrective improvements that are not Features nor Bugs. This includes restructuring for long-term maintainability, stability, reducing technical debt, improving the contributor experience, or upgrading dependencies.
See the handbook for more guidance on classifying.
This message was created with automation and Engineering Productivity is looking for feedback in this issue:
https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues/43
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for f6c4044cexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Manage | 37 | 0 | 2 | 39 | 39 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 123 | 0 | 9 | 125 | 132 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
removed review request for @krasio
added 1 commit
- e33d89f7 - Reset number of jobs attempts during `finalize`
- A deleted user
added featureaddition typefeature labels
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Ethan Urie
- Resolved by Ethan Urie
requested review from @a_luna
requested review from @igor.drozdov
- Resolved by Amparo Luna
- Resolved by Amparo Luna
- Resolved by Amparo Luna
- Resolved by Amparo Luna
- Resolved by Ethan Urie
removed review request for @a_luna
added 1 commit
- 40fc9e45 - Mock function to return the batched background migration
requested review from @jschafer
- Resolved by Ethan Urie
requested review from @krasio and removed review request for @igor.drozdov
@igor.drozdov
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @jschafer
- Resolved by Ethan Urie
removed review request for @krasio
requested review from @jschafer
requested review from @krasio
added 1170 commits
Toggle commit list- A deleted user
added database label
added databaseapproved label and removed databaseactive label
removed review request for @krasio
- Resolved by Ethan Urie
removed review request for @eurie
added 1 commit
- f6c4044c - Use BatchedJob::MAX_ATTEMPTS to define max_attempts
requested review from @eurie
enabled an automatic merge when the pipeline for 62c6c467 succeeds
mentioned in commit ef8e39a2
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue #360377 (closed)
nice! Thanks @dfrazao-gitlab
added groupdatabase frameworks label and removed groupdatabase [DEPRECATED] label
added pipeline:mr-approved label