Skip to content

Navigate to commit before scrolling to draft comment

Phil Hughes requested to merge ph/350366/pendingCommentOnCommit into master

What does this MR do and why?

When a user leaves a comment on a commit diff and then selects the pending comment the user will not be scrolled to the draft note. This changes that by first navigating to the commit diff.

Note There is already a bug where scrolling to a draft note that is not rendered in the DOM will not work, this should be fixed in a different issue.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Closes #350366 (closed)

Closes #350366 (closed)

Merge request reports