Skip to content
Snippets Groups Projects

Fix autocomplete in wikis

Merged Himanshu Kapoor requested to merge himkp-wiki-autocomplete into master
All threads resolved!

What does this MR do and why?

Currently, autocomplete is completely broken in wikis. Wikis traditionally do not support quick actions, but rest of autocomplete items should work correctly. (Including members, issues, MRs, epics, etc.)

Screenshots or screen recordings

image

How to set up and validate locally

  1. Open any wiki page
  2. Type in @, ~, !, #, % etc to bring up respective autocomplete items (members, labels, MRs, issues, milestones etc)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Himanshu Kapoor

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Nikola Milojevic approved this merge request

    approved this merge request

  • :wave: @nmilojevic1, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Nikola Milojevic removed review request for @nmilojevic1

    removed review request for @nmilojevic1

  • Anastasia McDonald approved this merge request

    approved this merge request

  • Anastasia McDonald removed review request for @a_mcdonald

    removed review request for @a_mcdonald

  • Himanshu Kapoor requested review from @a_mcdonald

    requested review from @a_mcdonald

  • Author Maintainer

    @kushalpandya Do you mind maintainerizing frontend and merging if it all looks good? Thanks

  • Himanshu Kapoor requested review from @kushalpandya and removed review request for @a_mcdonald

    requested review from @kushalpandya and removed review request for @a_mcdonald

  • Himanshu Kapoor resolved all threads

    resolved all threads

  • Kushal Pandya approved this merge request

    approved this merge request

  • merged

  • @kushalpandya, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:

    1. Ensure the merge request is not in Draft status.
    2. Start a pipeline (especially important for Community contribution merge requests).
    3. Set the merge request to merge when pipeline succeeds.

    This is a guideline, not a rule. Please consider replying to this comment for transparency.

    (Improve this message?)

  • Kushal Pandya mentioned in commit 59755ed5

    mentioned in commit 59755ed5

  • added workflowstaging label and removed workflowcanary label

  • Himanshu Kapoor mentioned in merge request !90753 (merged)

    mentioned in merge request !90753 (merged)

  • mentioned in issue #361446 (closed)

  • Please register or sign in to reply
    Loading