Fix autocomplete in wikis
What does this MR do and why?
Currently, autocomplete is completely broken in wikis. Wikis traditionally do not support quick actions, but rest of autocomplete items should work correctly. (Including members, issues, MRs, epics, etc.)
Screenshots or screen recordings
How to set up and validate locally
- Open any wiki page
- Type in
@
,~
,!
,#
,%
etc to bring up respective autocomplete items (members, labels, MRs, issues, milestones etc)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @himkp
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @kushalpandya
,@alexkalderimis
,@jivanvl
,@lulalala
,@iamphill
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botadded Category:Wiki devopscreate groupeditor [DEPRECATED] typebug + 1 deleted label
1 Warning This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Serena Fang ( @serenafang
) (UTC-5, 7 hours behind@himkp
)Terri Chu ( @terrichu
) (UTC-4, 6 hours behind@himkp
)frontend Briley Sandlin ( @bsandlin
) (UTC-5, 7 hours behind@himkp
)Jose Ivan Vargas ( @jivanvl
) (UTC+0, 2 hours behind@himkp
)test for spec/features/*
Anastasia McDonald ( @a_mcdonald
) (UTC+12, 10 hours ahead of@himkp
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangerchanged milestone to %15.2
- Resolved by Anastasia McDonald
@a_mcdonald Could you please review the feature specs? Thanks!
requested review from @a_mcdonald
- Resolved by Himanshu Kapoor
@nmilojevic1 Do you mind maintainerizing backend? Since this is a small change, I'm directly assigning it to you. Hope that's okay!
requested review from @nmilojevic1
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for d67a2844expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Verify | 12 | 0 | 1 | 2 | 13 | ❗ | | Create | 23 | 0 | 2 | 6 | 25 | ❗ | | Plan | 48 | 0 | 1 | 3 | 49 | ❗ | | Manage | 37 | 0 | 2 | 2 | 39 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 4 | 0 | 0 | 0 | 4 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 126 | 0 | 9 | 15 | 135 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
package-and-qa:
test report for fc14a8a4expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Plan | 325 | 1 | 6 | 0 | 332 | ❌ | | Package | 161 | 0 | 21 | 0 | 182 | ✅ | | Verify | 240 | 0 | 18 | 0 | 258 | ✅ | | Create | 921 | 0 | 38 | 4 | 959 | ❗ | | Manage | 628 | 0 | 18 | 1 | 646 | ❗ | | Fulfillment | 13 | 0 | 66 | 0 | 79 | ✅ | | Secure | 126 | 0 | 12 | 0 | 138 | ✅ | | Release | 36 | 0 | 0 | 0 | 36 | ✅ | | Product Intelligence | 13 | 0 | 0 | 0 | 13 | ✅ | | Configure | 1 | 0 | 18 | 0 | 19 | ✅ | | Enablement:Search | 9 | 0 | 1 | 0 | 10 | ✅ | | Protect | 12 | 0 | 0 | 0 | 12 | ✅ | | Version sanity check | 0 | 0 | 6 | 0 | 6 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 2485 | 1 | 204 | 5 | 2690 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Himanshu Kapoor
- The
gitlab-qa-mirror
downstream pipeline for !90709 (fc14a8a4) failed!
- The
- Resolved by Anastasia McDonald
@nmilojevic1
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @nmilojevic1
removed review request for @a_mcdonald
- Resolved by Himanshu Kapoor
@a_mcdonald Thanks for approving. The MR is already approved for backend, so could you please merge it? Thanks!
requested review from @a_mcdonald
@kushalpandya Do you mind maintainerizing frontend and merging if it all looks good? Thanks
requested review from @kushalpandya and removed review request for @a_mcdonald
@kushalpandya, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to merge when pipeline succeeds.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
mentioned in commit 59755ed5
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue gitlab-org/quality/pipeline-triage#151 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#152 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#153 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)
mentioned in merge request !90753 (merged)
mentioned in issue #361446 (closed)