Skip to content

Moves ipynbdiff to vendor

Eduardo Bonet requested to merge move-rb-ipynbdiff-to-vendor into master

What does this MR do and why?

gitlab-org/incubation-engineering/mlops/rb-ipynbdiff started as a library intended for general use, but the code is very tied to gitlab usage. As such, we are moving the library to vendor to keep it consistent with the rest of the codebase and easier to find, and avoid upgrading the library on every bug fix

Screenshots or screen recordings

This is a pure refactor, copying rb-ipynbdiff at revision fa47e70723dfee918697e94aaa5a4bd6e9da0ce7 into gitlab repo.

How to set up and validate locally

  • Tests should pass correctly
  • Open a commit with a notebook (eg gitlab-test@5d6ed150) and make sure the diff is generated correctly

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Eduardo Bonet

Merge request reports