Bump highligh.js and lowlight syntax highlighting
What does this MR do and why?
This MR bumps highlight.js
to 11.15.1
and lowlight
to 2.6.1
to add some
improvements to syntax highlighting on GitLab.
Screenshots or screen recordings
There are no visual differences noted between the two versions.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- In rails console enable the
hightlight_js
experiment fullyFeature.enable(:hightlight_js)
- View a file
http://gdk.test:3000/gitlab-org/gitlab-shell/-/blob/main/client/httpclient.go
- Confirm the syntax highlight is not visually different compared to the file in production
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @tle_gitlab
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@mayra-cabrera
,@tkuah
,@filipa
,@marcel.amirault
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botmarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Mireya Andres ( @mgandres
) (UTC+8)Miguel Rincon ( @mrincon
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7c6f055e and d0a8b9fc
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.54 MB 3.54 MB - -0.0 % mainChunk 1.98 MB 1.98 MB - 0.0 %
Note: We do not have exact data for 7c6f055e. So we have used data from: 2e888a8a.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 241 commits
-
76d22a1d...3b703986 - 240 commits from branch
master
- b6096beb - Bump highligh.js and lowlight syntax highlighting
-
76d22a1d...3b703986 - 240 commits from branch
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for d0a8b9fcexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Manage | 37 | 0 | 2 | 38 | 39 | ❗ | | Create | 23 | 0 | 2 | 22 | 25 | ❗ | | Secure | 4 | 0 | 0 | 4 | 4 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 126 | 0 | 9 | 126 | 135 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
package-and-qa:
test report for d0a8b9fcexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 927 | 0 | 38 | 6 | 965 | ❗ | | Verify | 240 | 0 | 18 | 0 | 258 | ✅ | | Manage | 628 | 0 | 18 | 11 | 646 | ❗ | | Plan | 326 | 0 | 6 | 0 | 332 | ✅ | | Secure | 126 | 0 | 12 | 4 | 138 | ❗ | | Product Intelligence | 13 | 0 | 0 | 0 | 13 | ✅ | | Configure | 1 | 0 | 18 | 0 | 19 | ✅ | | Release | 35 | 1 | 0 | 0 | 36 | ❌ | | Fulfillment | 15 | 0 | 66 | 0 | 81 | ✅ | | Package | 161 | 0 | 21 | 9 | 182 | ❗ | | Version sanity check | 0 | 0 | 6 | 0 | 6 | ➖ | | Protect | 12 | 0 | 0 | 0 | 12 | ✅ | | Enablement:Search | 9 | 0 | 1 | 0 | 10 | ✅ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 2493 | 1 | 204 | 30 | 2698 | ❌ | +----------------------+--------+--------+---------+-------+-------+--------+
- The
gitlab-qa-mirror
downstream pipeline for !90671 (b6096beb) failed! - The
gitlab-qa-mirror
downstream pipeline for !90671 (d0a8b9fc) passed. - The
gitlab-qa-mirror
downstream pipeline for !90671 (d0a8b9fc) failed!
- The
changed milestone to %15.2
added 282 commits
-
b6096beb...82773c2a - 281 commits from branch
master
- d0a8b9fc - Bump highligh.js and lowlight syntax highlighting
-
b6096beb...82773c2a - 281 commits from branch
added workflowready for review label
added Category:Source Code Management label
added frontend label
- Resolved by Natalia Tepluhina
@mgandres could you help to review this MR, please?
requested review from @mgandres
@mgandres
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @ntepluhina and removed review request for @mgandres
enabled an automatic merge when the pipeline for f6c17bad succeeds
mentioned in commit be8a7a58
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label