Skip to content
Snippets Groups Projects

Activate GitlabSchemaValidateConnection for all tests

Merged Omar Qunsul requested to merge gitlab-schemas-validate-connection-tests into master
All threads resolved!

What does this MR do and why?

After the Database Decomposition Project has been finished, we want to make sure that future features always access the right database for each table. That's why we are adding this feature to both development and test environments, to help the developers early on detect any possible issues. FYI, on Staging and Production we raise errors if you try to write to the wrong database.

In order to achieve this, as part of this MR we are enabling the Query Analyzer GitlabSchemasValidateConnection in Rspecs, to make sure that we are not reading/writing to the wrong database.

We are also suppressing this analyzer using the taint :suppress_gitlab_schemas_validate_connection on any old database migrations that happened to be writing to the CI tables on the Main database.

Issue: #365761 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Omar Qunsul

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Omar Qunsul added 164 commits

    added 164 commits

    Compare with previous version

  • Omar Qunsul added 59 commits

    added 59 commits

    Compare with previous version

  • Omar Qunsul added 34 commits

    added 34 commits

    Compare with previous version

  • Omar Qunsul added 3271 commits

    added 3271 commits

    Compare with previous version

  • Omar Qunsul added 124 commits

    added 124 commits

    Compare with previous version

  • Omar Qunsul added 1 commit

    added 1 commit

    • eb8bf050 - Activate GitlabSchemaValidateConnection for all tests

    Compare with previous version

  • Omar Qunsul changed the description

    changed the description

  • Omar Qunsul changed milestone to %15.3

    changed milestone to %15.3

  • Omar Qunsul added 123 commits

    added 123 commits

    Compare with previous version

  • Omar Qunsul marked this merge request as ready

    marked this merge request as ready

  • Omar Qunsul added 34 commits

    added 34 commits

    Compare with previous version

  • Omar Qunsul requested review from @rzwambag

    requested review from @rzwambag

  • Omar Qunsul requested review from @dgruzd

    requested review from @dgruzd

  • Omar Qunsul requested review from @michold

    requested review from @michold

  • Dmitry Gruzd
  • Dmitry Gruzd
  • Dmitry Gruzd
  • Dmitry Gruzd removed review request for @dgruzd

    removed review request for @dgruzd

  • Omar Qunsul added 283 commits

    added 283 commits

    Compare with previous version

  • Omar Qunsul requested review from @dgruzd

    requested review from @dgruzd

  • Dmitry Gruzd approved this merge request

    approved this merge request

  • added databasereviewed label and removed databasereview pending label

  • Dmitry Gruzd requested review from @tigerwnz and removed review request for @dgruzd

    requested review from @tigerwnz and removed review request for @dgruzd

  • :wave: @dgruzd, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Roy Zwambag approved this merge request

    approved this merge request

  • Roy Zwambag removed review request for @rzwambag

    removed review request for @rzwambag

  • Roy Zwambag requested review from @ebaque

    requested review from @ebaque

  • Omar Qunsul added 46 commits

    added 46 commits

    Compare with previous version

  • Omar Qunsul added 33 commits

    added 33 commits

    Compare with previous version

  • Tiger Watson approved this merge request

    approved this merge request

  • added databaseapproved label and removed databasereviewed label

  • Tiger Watson removed review request for @tigerwnz

    removed review request for @tigerwnz

  • Etienne Baqué approved this merge request

    approved this merge request

  • Michał Wielich approved this merge request

    approved this merge request

  • Michał Wielich removed review request for @michold

    removed review request for @michold

  • Etienne Baqué resolved all threads

    resolved all threads

  • Etienne Baqué enabled an automatic merge when the pipeline for 99ba5128 succeeds

    enabled an automatic merge when the pipeline for 99ba5128 succeeds

  • Etienne Baqué mentioned in commit 7116b1f0

    mentioned in commit 7116b1f0

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #368848 (closed)

  • Omar Qunsul mentioned in merge request !92333 (merged)

    mentioned in merge request !92333 (merged)

  • mentioned in issue #362345 (closed)

  • Please register or sign in to reply
    Loading