Application Settings Repository h4 Expand/Collapse
What does this MR do and why?
This MR updates section headers in Admin / Application Settings / Repository to expand/collapse on click/tap.
CSS classes settings-title
, js-settings-toggle
and js-settings-toggle-trigger-only
are added to header/h4
elements. This
enables the expand/collapse behavior on on-click / on-tap.
Project Settings headers (h4
elements) expand/collapse on mouse-click / tap and using the Expand/Collapse button. Most h4
headers in Admin / Application Settings pages do not expand/collapse on mouse-click / tap, but only using the Expand/Collapse button. This may seem inconsistent to the user.
Screenshots or screen recordings
Screen_Recording_2022-06-18_at_08.30.02
How to set up and validate locally
- Start GitLab locally, or in GitPod
- Open GitLab Admin / Application Settings / General (e.g. locally at http://127.0.0.1:3000/admin/application_settings/repository)
- Click or tap a
h4
header, e.g. Visibility and access controls - The section will expand / collapse
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN
. - You can comment
@gitlab-bot label ~"group::<group name>"
to add a group label or@gitlab-bot label ~"type::<type name>"
to add a type label. - When you're ready for a first review, just post
@gitlab-bot request_review
, and we'll take care of the rest. - If you need help moving the merge request forward, feel free to post
@gitlab-bot help
. - Read more on how to get help.
This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @quatauta
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aditya Tiwari ( @atiwari71
) (UTC+5.5)Douglas Barbosa Alexandre ( @dbalexandre
) (UTC+0)frontend Sharmad Nachnolkar ( @snachnolkar
) (UTC+5.5)Robert Hunt ( @rob.hunt
) (UTC+1)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerEdited by Daniel Schömer@gitlab-bot label frontend
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
mentioned in issue gitlab-org/quality/triage-reports#8035 (closed)
@gitlab-bot request_review
added workflowready for review label and removed workflowin dev label
mentioned in merge request !90568 (merged)
mentioned in merge request !90572 (merged)
added frontend groupsource code labels
- Resolved by Natalia Tepluhina
added devopsconfigure [DEPRECATED] sectiondev typefeature workflowin review labels and removed workflowready for review label
requested review from @rchanila
added 1 commit
- aed8f0fb - Application Settings Repository h4 Expand/Collapse
added UX label
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @iamphill
,@ntepluhina
,@eread
,@kushalpandya
,@mrincon
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aditya Tiwari ( @atiwari71
) (UTC+5.5)Douglas Barbosa Alexandre ( @dbalexandre
) (UTC+0)frontend Mireya Andres ( @mgandres
) (UTC+8)Natalia Tepluhina ( @ntepluhina
) (UTC+2)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangerrequested review from @nadia_sotnikova
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for aed8f0fbexpand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 22 | 25 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Manage | 37 | 0 | 2 | 38 | 39 | ❗ | | Secure | 6 | 0 | 0 | 6 | 6 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 128 | 0 | 9 | 128 | 137 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
requested review from @ntepluhina and removed review request for @rchanila
- Resolved by Natalia Tepluhina
@rchanila
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
removed review request for @nadia_sotnikova
@quatauta, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
- Leave a
mentioned in commit 49e683b8
mentioned in merge request !90701 (merged)
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
mentioned in merge request !90737 (merged)
added workflowproduction label and removed workflowstaging label
mentioned in merge request !90743 (merged)
mentioned in merge request !90745 (merged)
changed milestone to %15.2
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)