Enable closed_as_duplicate_of in issues API
What does this MR do and why?
After enabling on GitLab.com (#364749 (comment 993460181)) and not seeing any perf issues, this removes the FF to add closed_as_duplicate_of
to the Issues API response permanently.
Monitoring can be done here: #364749 (closed). Performance seems stable since enabled.
Documentation has already been added in https://docs.gitlab.com/ee/api/issues.html.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #364749 (closed)
Merge request reports
Activity
assigned to @seanarnold
mentioned in issue #364749 (closed)
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rymai
,@Andysoiron
,@engwan
,@tkuah
,@aqualls
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request does not refer to an existing milestone. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ross Fuhrman ( @rossfuhrman
) (UTC-5, 17 hours behind@seanarnold
)Igor Drozdov ( @igor.drozdov
) (UTC+2, 10 hours behind@seanarnold
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Allure report
allure-report-publisher
generated test report!package-and-qa-ff-deleted:
test report for 4c13ae01expand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ | Plan | 53 | 0 | 1 | 0 | 54 | ✅ | +-------+--------+--------+---------+-------+-------+--------+ | Total | 53 | 0 | 1 | 0 | 54 | ✅ | +-------+--------+--------+---------+-------+-------+--------+
- The
gitlab-qa-mirror
downstream pipeline for !90457 (ea48fb04) passed. - The
gitlab-qa-mirror
downstream pipeline for !90457 (ea48fb04) failed! - The
gitlab-qa-mirror
downstream pipeline for !90457 (4c13ae01) passed. - The
gitlab-qa-mirror
downstream pipeline for !90457 (4c13ae01) passed.
- The
- Resolved by Bob Van Landuyt
@sashi_kumar Can you review this please?
requested review from @sashi_kumar
requested review from @kerrizor and removed review request for @sashi_kumar
@sashi_kumar
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @reprazent and removed review request for @kerrizor
added 909 commits
-
ea48fb04...de4590d9 - 908 commits from branch
master
- 4c13ae01 - Enable closed_as_duplicate_of in issues API
-
ea48fb04...de4590d9 - 908 commits from branch
enabled an automatic merge when the pipeline for 7ecb6f20 succeeds
Thanks @seanarnold
mentioned in commit 4418fb7b
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)