Skip to content

Refactor CreatorService for creating members

Doug Stull requested to merge 354016-resolve-growing-query-with-more-invites-userid into master

What does this MR do and why?

  • Naming changes to better reflect we are adding members instead of users as user is overloaded and is easy to confuse with the model user when we are in reality creating a member record. Also, members can be by user or by email for people not registered in the product
    • change add_user to add_member
    • change add_users to add_members
    • change user to invitee in the CreatorService
    • change users to invitees in add_members class method
  • General refactoring
    • CreatorService for readability and long term management.
  • Added query count on Invitations API for adding members by id

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #354016 (closed)

Edited by Doug Stull

Merge request reports