Migrates the spacing class for discussion filters
What does this MR do and why?
Migrates the spacing class for discussion filters. It also fixes the margin between the two buttons.
Before | After |
---|---|
![]() |
![]() |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.1
assigned to @mvanremmerden
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @kushalpandya
,@ntepluhina
,@shampton
,@ealcantara
,@sarahghp
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Dave Pisek ( @dpisek
) (UTC+10)Simon Knox ( @psimyn
) (UTC+10)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger- Resolved by Natalia Tepluhina
@cngo Another small class migration MR for you.
requested review from @cngo
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 910a92f0 and b89b9b72
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.54 MB 3.54 MB - 0.0 % mainChunk 1.98 MB 1.98 MB - 0.0 %
Note: We do not have exact data for 910a92f0. So we have used data from: b64dd317.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for b89b9b72expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Secure | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 48 | 0 | 1 | 0 | 49 | ✅ | | Create | 23 | 0 | 2 | 0 | 25 | ✅ | | Verify | 12 | 0 | 1 | 0 | 13 | ✅ | | Manage | 36 | 0 | 2 | 0 | 38 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 127 | 0 | 9 | 0 | 136 | ✅ | +----------------------+--------+--------+---------+-------+-------+--------+
requested review from @ntepluhina and removed review request for @cngo
@cngo
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for fc199ebe succeeds
added 283 commits
-
3b8f7578...910a92f0 - 282 commits from branch
master
- b89b9b72 - Migrates the spacing class for discussion filters
-
3b8f7578...910a92f0 - 282 commits from branch
enabled an automatic merge when the pipeline for b0675ce4 succeeds
mentioned in commit 4a8d74b8
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)