Skip to content

Backend support for manipulating web-hook variables (REST)

Alex Kalderimis requested to merge 361124-webhook-encrypted-tokens-backend-support-rest into master

What does this MR do and why?

See: #361124 (closed)

This makes the following changes:

  • REST endpoints accept URL parameters on POST and PUT
  • URL variable names are returned in serialized entities

Tests are heavily refactored so we have one shared set of specs for project, group and system hooks, with shared implementations for the new URL variable endpoints. A JSON schema for project hooks is added.

Unifies error handling across hooks API endpoints

Prior to this change, different endpoints handled validation errors differently.

This change ensures that all validation errors are returned as 422 unprocessable.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alex Kalderimis

Merge request reports