Remove security report latest pipeline fallback calculation
What does this MR do and why?
This fallback calculation was implemented until we could have the latest pipeline data populated in the database. Now that the background migrations have completed, this calculation is no longer needed and can be removed, per #331950 (closed).
Screenshots or screen recordings
There are no screenshots to show for this MR.
How to set up and validate locally
- Set the branch to
master
- Go to the Vulnerability Report of a project with vulnerabilities
- Note the last updated field exists.
- Open a rails console
- Get the project's vulnerability statistic
vs = Project.find(<project.id>).vulnerability_statistic
- Clear the latest_pipeline_id
vs.update_attribute(:latest_pipeline_id, nil)
- On the Vulnerability Report, the last updated field still exists.
- Set the branch to
331950-remove-the-fallback-to-on-the-fly-calculation-of-latest-pipeline-with-security-reports
- On the Vulnerability Report, the last updated field no longer exists, as the backup method has been removed.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #331950 (closed)
Merge request reports
Activity
changed milestone to %15.2
assigned to @jschafer
added typebug label and removed typemaintenance label
added 1 commit
- 0fe34275 - Remove fallback calc of last sec report pipeline
mentioned in issue #331950 (closed)
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rymai
,@ashmckenzie
,@gitlab-bot
,@kushalpandya
,@sabrams
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Botmentioned in merge request !68340 (closed)
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Dallas Reedy ( @dreedy
) (UTC-7, 2 hours behind@jschafer
)Dylan Griffith ( @DylanGriffith
) (UTC+10, 15 hours ahead of@jschafer
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 0ae32a97expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Manage | 37 | 0 | 2 | 38 | 39 | ❗ | | Secure | 4 | 0 | 0 | 4 | 4 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 126 | 0 | 9 | 127 | 135 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 6e44eda7 - Remove fallback calc of last sec report pipeline
added 1 commit
- c5ae8b0a - Remove fallback calc of last sec report pipeline
added 1 commit
- 4bb968f5 - Remove fallback calc of last sec report pipeline
added 1 commit
- 48d73c8e - Remove fallback calc of last sec report pipeline
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Dylan Griffith
@nbelokolodov can you review this MR please? There is a QA failure, but it looks unrelated. I am rebasing to see if it clears the failure.
added workflowin review label and removed workflowin dev label
requested review from @nbelokolodov