Skip to content
Snippets Groups Projects

Fix: notify locale on reassigned issueable email

All threads resolved!

What does this MR do and why?

Fix the un-translated hardcoded string in the email template for reassigned issuable.

I think keeping these strings segmented is a better way than merging them into a gigantic string with conditions.

Describe in detail what your merge request does and why.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Markus Koller removed review request for @toupeira

    removed review request for @toupeira

  • Kevin Morrison approved this merge request

    approved this merge request

  • Wu Jeremy added 664 commits

    added 664 commits

    Compare with previous version

  • @gitlab-bot assign_reviewer @toupeira

  • requested review from @toupeira

  • @gitlab-bot assign_reviewer @kmorrison1

  • requested review from @kmorrison1

  • Vasilii Iakliushin added typebug label and removed typemaintenance label

    added typebug label and removed typemaintenance label

  • added emails label

  • Wu Jeremy added 1 commit

    added 1 commit

    • 2787bb22 - Fix typo and remove unnecessary code

    Compare with previous version

  • @kmorrison1 hi, I just updated the code as suggested, would you mind reviewing this from security again? :bow:

  • Markus Koller approved this merge request

    approved this merge request

  • Markus Koller changed milestone to %15.2

    changed milestone to %15.2

  • Kevin Morrison unapproved this merge request

    unapproved this merge request

  • Kevin Morrison approved this merge request

    approved this merge request

  • Kevin Morrison resolved all threads

    resolved all threads

  • Markus Koller enabled an automatic merge when the pipeline for 2bc76e41 succeeds

    enabled an automatic merge when the pipeline for 2bc76e41 succeeds

  • Markus Koller resolved all threads

    resolved all threads

  • merged

  • @JeremyWuuuuu, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. Leave a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.

    Thanks for your help! :heart:

  • Markus Koller mentioned in commit b66c2a64

    mentioned in commit b66c2a64

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading