Fix: notify locale on reassigned issueable email
What does this MR do and why?
Fix the un-translated hardcoded string in the email template for reassigned issuable.
I think keeping these strings segmented is a better way than merging them into a gigantic string with conditions.
Describe in detail what your merge request does and why.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
added JiHu contribution label
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN
. - You can comment
@gitlab-bot label ~"group::<group name>"
to add a group label or@gitlab-bot label ~"type::<type name>"
to add a type label. - When you're ready for a first review, just post
@gitlab-bot request_review
, and we'll take care of the rest. - If you need help moving the merge request forward, feel free to post
@gitlab-bot help
. - Read more on how to get help.
This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @JeremyWuuuuu
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.This merge request does not refer to an existing milestone. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sam Figueroa ( @sam.figueroa
) (UTC+0)Igor Drozdov ( @igor.drozdov
) (UTC+2)frontend Tomas Vik ( @viktomas
) (UTC+2)Andrew Fontaine ( @afontaine
) (UTC-4)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Danger@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
@gitlab-bot assign_reviewer @iamricecake hi, would you mind reviewing this? Thanks!
requested review from @iamricecake
- Resolved by Florie Guibert
@gitlab-bot assign_reviewer @rchanila hi, would you mind reviewing this? Thank you!
requested review from @rchanila
mentioned in issue gitlab-org/quality/triage-reports#7988 (closed)
added typemaintenance label
removed typemaintenance label
added typemaintenance label
added frontend label
mentioned in issue gitlab-org/quality/triage-reports#7990 (closed)
- Resolved by Florie Guibert
@rchanila
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
- Resolved by Kevin Morrison
@rchanila
, thanks for approving this merge request.This is the first time the merge request is approved. Please wait for AppSec approval.
cc @gitlab-com/gl-security/appsec this is a JiHu contribution, please follow the JiHu contribution review process.
enabled an automatic merge when the pipeline for 1e47c208 succeeds
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @ashmckenzie
,@rymai
,@rpereira2
,@splattael
,@pslaughter
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
If needed, you can retry the
danger-review
job that generated this comment.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Dominic Bauer ( @bauerdominic
) (UTC+2)Mayra Cabrera ( @mayra-cabrera
) (UTC-5)frontend Doug Stull ( @dstull
) (UTC-4)Florie Guibert ( @fguibert
) (UTC+10)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
DangerAllure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for 2787bb22expand test summary
+---------------------------------------------------------------------------+ | suites summary | +----------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------------+--------+--------+---------+-------+-------+--------+ | Create | 23 | 0 | 2 | 22 | 25 | ❗ | | Plan | 48 | 0 | 1 | 48 | 49 | ❗ | | Manage | 37 | 0 | 2 | 38 | 39 | ❗ | | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Secure | 4 | 0 | 0 | 4 | 4 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +----------------------+--------+--------+---------+-------+-------+--------+ | Total | 126 | 0 | 9 | 126 | 135 | ❗ | +----------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Markus Koller
@JeremyWuuuuu thank you for your contribution. Backend LGTM
@toupeira can you please do the backend maintainer review?
requested review from @toupeira
- Resolved by Markus Koller
added workflowin dev label and removed workflowready for review label
removed review request for @toupeira
added sec-planningcomplete label
mentioned in issue gitlab-org/quality/triage-reports#8035 (closed)
added 664 commits
-
c502e475...5ff6acd9 - 661 commits from branch
gitlab-org:master
- 050f793e - Fix: notify locale on reassigned issueable email
- 87af6549 - Fix haml linter issue
- 33c07ba5 - Merge splitted strings into one
Toggle commit list-
c502e475...5ff6acd9 - 661 commits from branch
added sec-planningpending-followup label and removed sec-planningcomplete label
@gitlab-bot assign_reviewer @toupeira
requested review from @toupeira
@gitlab-bot assign_reviewer @kmorrison1
requested review from @kmorrison1
added typebug label and removed typemaintenance label
- Resolved by Markus Koller
added emails label
- Resolved by Markus Koller
@kmorrison1 hi, I just updated the code as suggested, would you mind reviewing this from security again?
mentioned in issue gitlab-org/quality/triage-reports#8051 (closed)
added devopsplan groupproject management labels
changed milestone to %15.2
removed sec-planningpending-followup label
added sec-planningcomplete label
- Resolved by Markus Koller
@kmorrison1 @JeremyWuuuuu thanks, I'll set this to MWPS now!
enabled an automatic merge when the pipeline for 2bc76e41 succeeds
mentioned in issue gitlab-jh/status-reports#143
@JeremyWuuuuu, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
- Leave a
mentioned in commit b66c2a64
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)