Skip to content

Removes stylesheets/pages/pages.scss

Sam Beckham requested to merge 239860-pages-page-specific-styles into master

What does this MR do and why?

As part of the effort to extract page specific CSS files this MR removes the styles in stylesheets/pages/pages.scss and converts them to use GitLab UI utility classes instead.

The main reason for doing this is that currently, this style sheet is imported onto every single GitLab page. Whilst that's not a huge amount of extra code, it all adds up.

Screenshots or screen recordings

Because this MR aims to replace the CSS, if I've done it right, nothing changes at all.

Before After
Screenshot_2022-06-14_at_10.49.23 Screenshot_2022-06-14_at_10.53.59
Screenshot_2022-06-14_at_10.49.08 Screenshot_2022-06-14_at_10.49.11

Walkthrough of the last element:

https://youtu.be/Xk-jEJfX2yA

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Set up your GDK with a project that uses GitLab Pages.
  2. Allow custom domains on your gitlab pages instance docs
  3. Add some custom domains and verify them
  4. Check the domain list
  5. Check the verified badge

Note: These steps aren't easy. I've recorded a video walkthrough to make seeing and understanding the change a little easier.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #239860 (closed)

Edited by Sam Beckham

Merge request reports