Simplify issue policy, allow bots metadata access
What does this MR do and why?
This fixes a bug where quick actions would not be processed for Incidents created automatically when an Alert is created. This behaviour is described here https://docs.gitlab.com/ee/operations/incident_management/incidents.html#create-incidents-automatically
I simplified the logic by using can?(:admin_user)
instead of checking if the user was an admin, which I believe keeps the same results.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
- Create an alert endpoint https://docs.gitlab.com/ee/operations/incident_management/integrations.html#single-http-endpoint
- In the settings, enable creating Incidents automatically
- Create an issue template that includes quick actions (i.e adding a label)
- POST a request to the alert endpoint
- The Incident issue that was created should have applied the labels.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #353637 (closed)
Merge request reports
Activity
changed milestone to %15.1
assigned to @seanarnold
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@rymai
,@mayra-cabrera
,@digitalmoksha
,@seanarnold
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- Resolved by Mayra Cabrera
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Tarun Vellishetty ( @tvellishetty
) (UTC+5.5, 6.5 hours behind@seanarnold
)Alexandru Croitor ( @acroitor
) (UTC+3, 9 hours behind@seanarnold
)UX Matthew Nearents ( @mnearents
) (UTC-7, 19 hours behind@seanarnold
)Pedro Moreira da Silva ( @pedroms
) (UTC+1, 11 hours behind@seanarnold
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Generated by
Dangermarked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Mayra Cabrera
@cwoolley-gitlab are you able to review this please?
requested review from @cwoolley-gitlab
requested review from @mayra-cabrera and removed review request for @cwoolley-gitlab
@cwoolley-gitlab
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Mayra Cabrera
- Resolved by Mayra Cabrera
- Resolved by Mayra Cabrera
removed review request for @mayra-cabrera
requested review from @mayra-cabrera
removed [deprecated] Accepting merge requests label
- Resolved by Sean Arnold
requested review from @vdesousa
removed review request for @mayra-cabrera
changed milestone to %15.2
added missed:15.1 label
mentioned in issue #353637 (closed)
requested review from @mayra-cabrera
enabled an automatic merge when the pipeline for 52106fb9 succeeds
Thanks @seanarnold! This LGTM, MWPS set
mentioned in commit 7f61cb2c
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)