Skip to content
Snippets Groups Projects

Simplify issue policy, allow bots metadata access

Merged Sean Arnold requested to merge 353637-fix-alert-bot-quick-actions into master
All threads resolved!

What does this MR do and why?

This fixes a bug where quick actions would not be processed for Incidents created automatically when an Alert is created. This behaviour is described here https://docs.gitlab.com/ee/operations/incident_management/incidents.html#create-incidents-automatically

I simplified the logic by using can?(:admin_user) instead of checking if the user was an admin, which I believe keeps the same results.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

  1. Create an alert endpoint https://docs.gitlab.com/ee/operations/incident_management/integrations.html#single-http-endpoint
  2. In the settings, enable creating Incidents automatically
  3. Create an issue template that includes quick actions (i.e adding a label)
  4. POST a request to the alert endpoint
  5. The Incident issue that was created should have applied the labels.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #353637 (closed)

Edited by Sean Arnold

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Tarun Vellishetty (@tvellishetty) (UTC+5.5, 6.5 hours behind @seanarnold) Alexandru Croitor (@acroitor) (UTC+3, 9 hours behind @seanarnold)
    UX Matthew Nearents (@mnearents) (UTC-7, 19 hours behind @seanarnold) Pedro Moreira da Silva (@pedroms) (UTC+1, 11 hours behind @seanarnold)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Generated by :no_entry_sign: Danger

  • Sean Arnold marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • requested review from @cwoolley-gitlab

  • Chad Woolley approved this merge request

    approved this merge request

  • Chad Woolley requested review from @mayra-cabrera and removed review request for @cwoolley-gitlab

    requested review from @mayra-cabrera and removed review request for @cwoolley-gitlab

  • :wave: @cwoolley-gitlab, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Mayra Cabrera
  • Mayra Cabrera
  • Mayra Cabrera
  • Mayra Cabrera removed review request for @mayra-cabrera

    removed review request for @mayra-cabrera

  • Sean Arnold requested review from @mayra-cabrera

    requested review from @mayra-cabrera

  • Alexandru Croitor approved this merge request

    approved this merge request

  • Sean Arnold added 1 commit

    added 1 commit

    • 7e15bc54 - Remove comment for set issue metadata

    Compare with previous version

  • Mayra Cabrera requested review from @vdesousa

    requested review from @vdesousa

  • Mayra Cabrera removed review request for @mayra-cabrera

    removed review request for @mayra-cabrera

  • 🤖 GitLab Bot 🤖 changed milestone to %15.2

    changed milestone to %15.2

  • mentioned in issue #353637 (closed)

  • requested review from @mayra-cabrera

  • Mayra Cabrera resolved all threads

    resolved all threads

  • Mayra Cabrera approved this merge request

    approved this merge request

  • Mayra Cabrera enabled an automatic merge when the pipeline for 52106fb9 succeeds

    enabled an automatic merge when the pipeline for 52106fb9 succeeds

  • Thanks @seanarnold! This LGTM, MWPS set :rocket:

  • merged

  • Mayra Cabrera mentioned in commit 7f61cb2c

    mentioned in commit 7f61cb2c

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading