Update ee admin settings error alerts
What does this MR do and why?
Update ee admin settings error alerts
- update bootstrap alert to Pajamas
Changelog: other
EE: true
Screenshots or screen recordings
Note: I had to force the errors on programatically, so there are no reasons for the errors
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Apply the below patch
- Navigate to admin => Settings => Templates => Custom project templates
- Navigate to admin => Settings => CI/CD => Required Pipeline Configuration
- Navigate to admin => Settings => Advanced Search
- Navigate to admin => Push Rules and disable the first line of
ee/app/views/admin/push_rules/_merge_request_approvals.html.haml
diff --git a/app/helpers/form_helper.rb b/app/helpers/form_helper.rb
index d2f1976e3c0..c7ceef2c480 100644
--- a/app/helpers/form_helper.rb
+++ b/app/helpers/form_helper.rb
@@ -4,7 +4,7 @@ module FormHelper
def form_errors(model, type: 'form', truncate: [], pajamas_alert: false)
errors = model.errors
- return unless errors.any?
+ return if errors.any?
headline = n_(
'The %{type} contains the following error:',
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #364956 (closed) Related to #364950 (closed) Related to #364975 (closed) Related to #364984 (closed)
Edited by Alexander Turinske