Skip to content

Make some admin general settings form errors pajamas compliant

Laura Callahan requested to merge 364895-form-error-pajamas into master

What does this MR do and why?

Related to #364895 (closed), #364892 (closed), #364889 (closed), #364894 (closed)

Makes form errors for some parts of the admin general settings page pajamas compliant

Screenshots or screen recordings

Before After
Screen_Shot_2022-06-10_at_3.19.02_PM Screen_Shot_2022-06-10_at_3.20.00_PM
Screen_Shot_2022-06-10_at_3.25.40_PM Screen_Shot_2022-06-10_at_3.27.17_PM
Screen_Shot_2022-06-10_at_3.28.38_PM Screen_Shot_2022-06-10_at_3.29.54_PM
Screen_Shot_2022-06-10_at_3.32.18_PM Screen_Shot_2022-06-10_at_3.33.10_PM

How to set up and validate locally

  • Navigate to /admin/application_settings/general
  • Expand Account and limit section
  • Enter a negative number in Maximum export size and save changes
  • Open Sourcegraph
  • Form error should be visible
  • Open kroki, error should be visible
  • Open terms of service, error should be visible
  • Open Federated Learning of Cohorts, error should be visible

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Laura Callahan

Merge request reports