Skip to content

Replacing pencil-square icon with pencil icon

Gina Doyle requested to merge gdoyle-master-patch-97420 into master

What does this MR do and why?

We are replacing all pencil-square icons with the pencil icon based on the latest Pajamas guidance that says pencil indicates something is editable/edit as an action. This MR replaces all instances of pencil-square with pencil.

Related to gitlab-org/gitlab-services/design.gitlab.com#1261 (closed)

Changelog: changed

Screenshots or screen recordings

page before after
admin > users Screen_Shot_2022-06-10_at_2.57.44_PM Screen_Shot_2022-06-13_at_9.18.06_AM
admin > broadcast messages Screen_Shot_2022-06-10_at_2.58.09_PM Screen_Shot_2022-06-13_at_9.18.47_AM
admin > groups Screen_Shot_2022-06-10_at_2.58.41_PM Screen_Shot_2022-06-13_at_9.19.17_AM
admin > projects > project details Screen_Shot_2022-06-10_at_2.59.09_PM Screen_Shot_2022-06-13_at_9.19.31_AM
admin > projects > project details > manage access group/project member Screen_Shot_2022-06-10_at_3.00.38_PM Screen_Shot_2022-06-13_at_9.19.48_AM
project > wiki > create new Screen_Shot_2022-06-10_at_3.01.07_PM Screen_Shot_2022-06-13_at_9.20.21_AM

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

1 scenario example:

  1. Go to admin area
  2. Go to users list

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Gina Doyle

Merge request reports