Skip to content

GraphQL: Test for N+1 issues in additional situations in RunnerType

Pedro Pombeiro requested to merge pedropombeiro/355740/1-fix-n+1-tests into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR:

  • improves the N+1 tests for RunnerType to also test the projects and groups properties, by adding project and group runners to the test query;
  • cleans up a bit the Types::Ci::RunnerType#batched_owners method
  • Requests only the id field for groups and projects, to constrain the max depth being tested.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Part of #355740 (closed)

Edited by Pedro Pombeiro

Merge request reports