Skip to content

Migrate edit profile errors to use Pajamas compliant alert

What does this MR do and why?

Related to #364994 (closed)

Migrates form error alerts in edit profile page to be Pajamas compliant. There are two ways that alerts are shown on this page.

  1. When the page is submitted via ajax in app/assets/javascripts/profile/profile.js#L87
  2. When the page is submitted not via Ajax and hits app/controllers/profiles_controller.rb#L36
    • This happens when changing your email because a password confirmation modal is shown and submits the form not via Ajax
    • This is not yet Pajamas compliant and will be updated in !89883 (closed)

Screenshots or screen recordings

Before After
Screen_Shot_2022-06-10_at_8.20.15_PM Screen_Shot_2022-06-10_at_8.19.51_PM

How to set up and validate locally

  1. Navigate to http://gdk.test:3000/-/profile
  2. Enter jlkfsdjdlf in the Website url field
  3. Submit the form

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports