Skip to content

Refactor tracing settings

Peter Leitzen requested to merge pl-refactor-tracing-settings into master

What does this MR do?

In order to make a new operations settings (Sentry Configuration) easy to add we need streamline some things:

  • Use helper method to find or build tracing setting
  • Only use the update action
  • Create Projects::Operations::UpdateService and inline EE::TracingSettingService
    • Possibly use nested attributes in projects to streamline update
  • Extract tracing view into own partial (see https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8786)
  • CE: Create empty settings operations controller
  • CE: Create a settings view with render_if_exists for tracing setting

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/23724

Does this MR meet the acceptance criteria?

Edited by Kamil Trzciński

Merge request reports