Skip to content

Migrate ultimate trial banner to VueComponent

Diana Zubova requested to merge dz/363989-migrate-button-on-tiral-callout into master

What does this MR do and why?

Migrate close button on Trial callout banner to ButtonComponent

Related to #363989 (closed)

Screenshots or screen recordings

Before After
Screenshot_2022-06-10_at_11.30.14 Screenshot_2022-06-10_at_11.29.21

How to set up and validate locally

  1. Adjust def render_dashboard_ultimate_trial(user) to always show the callout
Patch
diff --git a/ee/app/helpers/ee/users/callouts_helper.rb b/ee/app/helpers/ee/users/callouts_helper.rb
index d5676d21960..d66ea7b813c 100644
--- a/ee/app/helpers/ee/users/callouts_helper.rb
+++ b/ee/app/helpers/ee/users/callouts_helper.rb
@@ -48,10 +48,10 @@ def show_migrate_hashed_storage_warning?
 
       override :render_dashboard_ultimate_trial
       def render_dashboard_ultimate_trial(user)
-        return unless show_ultimate_trial?(user, ULTIMATE_TRIAL) &&
-          user_default_dashboard?(user) &&
-          !user.owns_paid_namespace? &&
-          user.owns_group_without_trial?
+        # return unless show_ultimate_trial?(user, ULTIMATE_TRIAL) &&
+        #   user_default_dashboard?(user) &&
+        #   !user.owns_paid_namespace? &&
+        #   user.owns_group_without_trial?
 
         render 'shared/ultimate_trial_callout_content'
       end
2. Open http://localhost:3000/

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Diana Zubova

Merge request reports